[#21515] - Set option by mime type, not by mode name
- Fixed in Code Base
- 18 Aug 2018
- Medium
- Build: staging
- # 21515
- Diff
- okonomiyaki3000:fix-mode-autoloading
User tests: Successful: Unsuccessful:
Pull Request for Issue #21451 .
Summary of Changes
We shall set the mode option by mime rather than by mode name. Because some modes such as 'less' are considered 'css' by Codemirror but are differentiated by mime type.
Testing Instructions
Open a less file with Codemirror. Before the patch it should be highlighted like css, after it will use less syntax highlighting. Auto formatting (select a block of code and hit shift-tab) should also be affected.
Probably also test some html, css, and js code to make sure it's still working as expected.
Expected result
Syntax highlighting and auto-formatting will work according to whatever language is being displayed.
Actual result
Well, it wasn't for 'less' and possibly some others.
Documentation Changes Required
Nope.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
:-)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21515.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21515.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-18 15:54:23 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Don't believe appveyor. He's a dirty liar.