[#2150] - Fixes duplicate inline script and styles when caching is enabled (https://github.com/joomla/joomla-platform/issues/673)
- Closed
- 28 Nov 2013
- Medium
- Build: master
- # 2150
- Diff
- creativeprogramming:patch-1
- Foreign ID 26551
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
joomla/joomla-platform#673
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=26551
I fixed module cache logic in order to consider the logic of the "script" and "style" objects of the document's head data array
This logic is already handled by JDocumentHTML->mergeHeadData() which is a function used also to reconstruct the document headers from cache pieces so this fix is an addition of a missing - but surely wanted and planned in origin by you - piece of code
https://github.com/joomla/joomla-cms/blob/master/libraries/joomla/document/html/html.php#L227-236
This is an old unresolved issue:
http://forum.joomla.org/viewtopic.php?f=615&t=719887
joomla/joomla-platform#673
Great!
Should we add same pull in 2.5?
Yes the issue and the fix is for both 3.x and 2.5.x, anyway please use last commit, now I tested against the issue on a 2.5.16 and a 3.2 also the optimized version and I fixed a wrong logic I added in last commits
Maybe another solution can be to rewrite the JDocument "HeadData array" in order to let it holding inline script and inline styles as arrays and not string buffers (why the need for this exception? it it will be like any other element it holds, as an array there will be no need for my patch)
@Denitz after some hours oft testing, I arrived to the conclusion that your original optimized version was perfect, sorry if I created confusion and doubted, but i was not fully with the mind in the problem, your code works like a charm, and solves also some potential issues of mine! I applied it! Thanks so much!
@brunobatista thanks for the feedback, it worked but wasn't perfect, use last commit please if you have it in production
@creativeprogramming ok thanks!
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2013-11-28 23:21:24 |
Works for me! Thanks!