J4 Issue ?
avatar chetanmadaan
chetanmadaan
8 Aug 2018

Steps to reproduce the issue

Go to Content >> Categories.
Make sure you have a category and then check the checkbox.
Click batch icon.
You see a popup with broken styling.

Expected result

com_content (Article Manager Popup is fine)
image

Actual result

image

System information (as much as possible)

Joomla! 4.0.0-alpha4

Additional comments

avatar chetanmadaan chetanmadaan - open - 8 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 8 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Aug 2018
avatar Quy Quy - change - 8 Aug 2018
Title
com_categories batch Popup styling in broken.
[4.0] com_categories batch Popup styling in broken.
avatar joomla-cms-bot joomla-cms-bot - edited - 8 Aug 2018
avatar brianteeman brianteeman - change - 8 Aug 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 8 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Aug 2018
Category com_categories Layout
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Aug 2018
Status New Confirmed
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Aug 2018

Issue confirmed, thanks for Report.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21473.

avatar infograf768
infograf768 - comment - 16 Aug 2018

After patching a bit /administrator/components/com_categories/tmpl/categories/default_batch_body.php

I can get here:
screen shot 2018-08-16 at 12 03 04

default_batch_body.php.zip

In fact some styling is also broken elsewhere (batch menu items and also batch articles, but not as bad),
That can be solved a bit as shown above (as back-end template is WIP, I wonder if it is worht it), but remains the fact that if choosing a category or menu item (for all batches) the "Do you want to move the items or make a copy of them? " is always displayed while it should only display for example when a category has been chosen.

See 3.8.x to see the correct behavior.
Ir goes from style="display: none;" to style="display: block;"

avatar infograf768
infograf768 - comment - 16 Aug 2018

@dgrammatiko
Display or not of the batch-copy-move id depends on
/build/media_src/layouts/joomla/html/batch/batch-WHATEVER.es6.js

(test here with Firefox)

Can you do something?

avatar infograf768
infograf768 - comment - 16 Aug 2018

We can also use the API and use in the default_batch_body.php this shorther code

		<?php if ($published >= 0) : ?>
			<div class="form-group col-md-6">
				<div class="controls">
					<?php echo JLayoutHelper::render('joomla.html.batch.item', array('extension' => $extension)); ?>
				</div>
			</div>
		<?php endif; ?>

But we still have the issue with js.

avatar dgrammatiko
dgrammatiko - comment - 16 Aug 2018

@infograf768 it's a simple fix I'll do a PR later on

avatar infograf768
infograf768 - comment - 18 Aug 2018

Please test #21697

Closing as we have a patch

avatar infograf768 infograf768 - change - 18 Aug 2018
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2018-08-18 17:25:43
Closed_By infograf768
avatar infograf768 infograf768 - close - 18 Aug 2018
avatar chetanmadaan
chetanmadaan - comment - 19 Aug 2018

I should say, Thank you to everyone involved.

Add a Comment

Login with GitHub to post a comment