[#21447] - [4.0] Installer review
- Fixed in Code Base
- 8 Aug 2018
- Medium
- Build: 4.0-dev
- # 21447
- Diff
- brianteeman:instaler-review
User tests: Successful: Unsuccessful:
Fixes lots of small things - shouldn't really be in a single PR but otherwise it would be merge conflict hell
- [a11y] Joomla logo is a decorative image only so should not have an alt description
- Remove duplicate system-message-container div - important so we have unique id
- fontawesome is include in the template.css by the sccs - no need to load it again
- update code comment it is super user not super admin etc
- use quote and quotename not q and qn
- namespace - JText
- Namespace JHtml
- [a11y] Help Docs link - add a link to the docs site and meaningful text for screenreaders to the "lightbulb"
- [a11y] Add h1 to the page
- [a11y] change section role=main to just < main >
- You can not use a custom element to display the noscript message - obviously that's not going to work because the custom element is javascript - inception
- [a11y] Move message about installing languages to be a caption
- [a11y] add scope to languages table
- [a11y] contrast on language version number
- [a11y] Section headings not nested correctly h1->h3 now h1->h2
- Namespace JFile
- Namespace Jfolder
- target blank on mysql8 link to docs
- [a11y] footer link color and hover fixes #21359
- Validate name of database fixes #15583
- remove all references to switcher - not being used and it breaks scss compile
- template.css after running npm build:css [note this hadn't been run for a while as it was missing from the build scripts] #21446
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
| Labels |
Added:
?
?
|
||
i did look in the system tests repo but couldnt see this test that is failing
@wilsonge the failing system test has been failing before this PR as well - for example
http://ci.joomla.org/joomla/joomla-cms/8186/15
For sure that's been a problem before. But given you've removed the h3 it searches for (I think) it's going to fail 100% of the time now rather than like 70% of the time
@brianteeman check for the function here: https://github.com/joomla-projects/joomla-browser/blob/v4.0.0/src/JoomlaBrowser.php
Installation and some other generic functions are part of Joomla Browser, you can search the function being called for installation on that file.
please ping me when this one is ready to merge, I will take care of the right merge order
Don;t merge anything yet - the database name validation regex isnt working
I have no idea why this isn't working
if (isset($options->db_name) && !preg_match('^[a-zA-Z_][0-9a-zA-Z_\$]*', $options->db_name))
go
no anything is good, its pulling still the old joomla-browser version, need to figure out how I can convince the system to load the new one
Seems there is something wrong, the installation doesn't work. I tried it locally and it ends with the follwing screen
So the system-testing is right
i have done lots of test installs - will check again - maybe something slipped in doing the cs fixes
And drone is now happy
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-08 15:56:26 |
| Closed_By | ⇒ | wilsonge |
And merged :) thanks!
/me wipes brow
@puneet0191 @rdeutz the change here to change the header level is breaking system tests - can you guys help @brianteeman with fixing the tests please