Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21413] - [4.0] Accessing property without checking the object state causing Joomla installer non-responsive

? Pending

User tests: Successful: Unsuccessful:

avatar corejoomla
corejoomla
5 Aug 2018

After installing Joomla, go to customization and select language say Hindi for installation. If the language cannot be installed, the server will not return any value, and the value is null. But the below code is accessing its properties without checking the data is null or not.

Pull Request for Issue # .

Summary of Changes

Added a check to see if the download URL object exists before accessing its properties.

Testing Instructions

Install Joomla v4.0.0.alpha4
After installation complete, click on Customize installation and select Hindi language to install
You should see success message or error message.

Expected result

Screen is not frozen

Actual result

Error message shown and redirected to final status page

Documentation Changes Required

avatar corejoomla corejoomla - open - 5 Aug 2018
avatar corejoomla corejoomla - change - 5 Aug 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2018
Category ⇒ Installation
avatar corejoomla corejoomla - change - 5 Aug 2018
Title
…
Bug fix for #21412
[4.0] Accessing property without checking the object state causing Joomla installer non-responsive #21412
avatar corejoomla corejoomla - edited - 5 Aug 2018
avatar corejoomla corejoomla - change - 5 Aug 2018
Title
…
[4.0] Accessing property without checking the object state causing Joomla installer non-responsive #21412
[4.0] Accessing property without checking the object state causing Joomla installer non-responsive
avatar corejoomla corejoomla - edited - 5 Aug 2018
avatar wojsmol
wojsmol - comment - 5 Aug 2018

@corejoomla Please fix this code style error

[FILE: .../github.com/joomla/joomla-cms/installation/src/Model/LanguagesModel.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 257 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if (...)
     |       | ...{...}\n...else\n"
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------]
avatar corejoomla corejoomla - change - 5 Aug 2018
Labels Added: ?
avatar wilsonge wilsonge - close - 6 Aug 2018
avatar wilsonge wilsonge - merge - 6 Aug 2018
avatar wilsonge wilsonge - change - 6 Aug 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-08-06 09:19:29
Closed_By ⇒ wilsonge
avatar wilsonge
wilsonge - comment - 6 Aug 2018

Nice find - thanks! Thanks for your first contribution to core!

Add a Comment

Login with GitHub to post a comment