User tests: Successful: Unsuccessful:
Code error in #21357
Making sure we are in multilang before using forcedLanguage.
Changing the code to get the article language as $this->element['language']
is wrong in this case.
Create a multingual site with articles set to some languages and other set to All languages.
When using the new "New Menu Item" button, the modal presented should take into account the language of the article for the Menu item created.
For an article tagged to ALL languages the language for the menu item can be anything (no forcedLanguage).
But for an article tagged to a specific language, the menu item should also be tagged to the same language.
This is unrelated to the Menu, which can be set to ALL or any language.
We can choose in the modal any language for the menu item.
When the article is not tagged to ALL, the new menu item is already tagged to the same language as the article and it can't be changed.
yes when doc is made for #21357
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_content |
Title |
|
test this Weekend now.
After save new Article no Button "New Menu Item" is shown.
I have tested this item
Works as expected after new Installation of Nightly (not Update as before).
@infograf768 did not thougt about this, thank you
@franz-wohlkoenig many thanks for testing again
@bene-we
Please set your test OK in https://issues.joomla.org/tracker/joomla-cms/21391 by using the blue button "Test this"
Note: will create the new PR for lang load separately.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-06 08:51:23 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks JM!
Note: I also think the language load can be simplified
from
to simply