Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21387] - fixed button description to language string

? Pending

User tests: Successful: Unsuccessful:

avatar bene-we
bene-we
3 Aug 2018

Pull Request for Issue #21357 .

Summary of Changes

Fixed language string

Testing Instructions

See if the button text is still the same

avatar bene-we bene-we - open - 3 Aug 2018
avatar bene-we bene-we - change - 3 Aug 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2018
Category ⇒ Administration com_content Language & Strings
avatar brianteeman brianteeman - test_item - 3 Aug 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 3 Aug 2018

I have tested this item ✅ successfully on 410efa2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21387.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 3 Aug 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Aug 2018

I have tested this item ✅ successfully on 410efa2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21387.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Aug 2018
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Aug 2018

Ready to Commit after two successful tests.

avatar SharkyKZ
SharkyKZ - comment - 3 Aug 2018

Use existing COM_MENUS_ITEM_VIEW_EDIT_TITLE?

avatar mbabker
mbabker - comment - 3 Aug 2018

Use existing COM_MENUS_ITEM_VIEW_EDIT_TITLE?

That means loading the com_menus language strings in com_content. If you're going to make a global string, put it in a global file. Otherwise, randomly including component language files is a bad idea, especially the way they quite commonly override other language strings.

avatar SharkyKZ
SharkyKZ - comment - 3 Aug 2018

@mbabker Suggesting this because com_menus is being loaded anyways.

joomla-cms/administrator/components/com_content/View/Article/HtmlView.php

Lines 216 to 220 in 410efa2

// Load the language files
$language = Factory::getLanguage();
$language->load('com_menus', JPATH_ADMINISTRATOR, 'en-GB');
$language->load('com_menus', JPATH_ADMINISTRATOR, $language->getDefault());
$language->load('com_menus', JPATH_ADMINISTRATOR);

But I agree. Actually, the whole feature should be made available globally instead of being hardcoded into com_content. It doesn't depend on content type anyways.

avatar wilsonge wilsonge - change - 3 Aug 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-08-03 15:20:12
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 3 Aug 2018
avatar wilsonge wilsonge - merge - 3 Aug 2018
avatar wilsonge
wilsonge - comment - 3 Aug 2018

Thanks

Add a Comment

Login with GitHub to post a comment