I have tested this item ? unsuccessfully on 35e8d5b

19999 is saved and Message shows Constant.

Please ignore Test as for now Front- and Backend-PRs are able to test by Patchtester.

Use error from model:
$this->app->enqueueMessage($model->getError(), 'error');

I have not tested this item.

I have tested this item ? unsuccessfully on 35e8d5b

19999 is saved and Message shows Constant.

Is the PR missing the string being added to the language file?

@Twincarb yes

FILE: ...dministrator/components/com_config/Controller/ApplicationController.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 122 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 123 | ERROR | Tabs must be used to indent lines; spaces are not allowed
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

Codestyle fixed

I have tested this item ✅ successfully on 1a3c4eb

I have tested this item ? unsuccessfully on 1a3c4eb

Language String shown correct, but incorrect value for "session lifetime" "19999" is saved

System information

• Nightly Build 4.0.0-alpha5-dev
• Multilingual Sample Data (French, German DE, Persian)
• Template: Cassiopeia
• macOS Sierra, 10.13.6
• Firefox 61 (64-bit)

CloudAccess.net

• PHP 7.1.15
• MySQLi 5.7.18-cll-lve.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21384.}

Hi,

The "session lifetime" is not saved in the configuration ; it is coming from the session which store the form data to not loose what the user was editing.
So the user know that the configuration is not saved but its form is kept which allow him to fix what is wrong (but he need to know what is wrong)

There is a comment saying that the model should display the error message (which is not the case and we don't know why).

The validate method enqueued all messages for us, so we just need to redirect back.

Letting the model display the errors or pushing the errors from the model is a requirement because the user must know what is going from with the provided data.
The patch fix the issue but it would require further improvements to have a good user experience.

Regards,

Using "Blanks" before or after the value is accepted.
No error message - the value after saving is 15.
Example " 18005", "18005 " is value "15" after saving

Proposed solution, trim before check.

I have tested this item ? unsuccessfully on 88726e0

#
Language String is shown correct, but incorrect value for "session lifetime" "19999" is saved

System information
Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
Web Server : Apache
WebServer to PHP Interface : cgi-fcgi
PHP 7.3.8
MySQL 5.7.23-cll-lve

Hi,
Now language string showing a correct message and also incorrect value for "session lifetime" "19999" is not storing in config.php
But In the backend UI System -> Global Configuration still showing "19999" this value under "session lifetime".

This is no longer an issue.