Feeling Lucky
?
?
[#21370] - Fix unit tests for PostgreSQL 10
- Fixed in Code Base
- 6 Aug 2018
- Medium
- Build: staging
- # 21370
- Diff
- csthomas:fix_postgres_unittests
User tests: Successful: Unsuccessful:
Pull Request for Issue #20114
Summary of Changes
Check PostgreSQL version before compare query results.
The same as in joomla-framework/database#125
Testing Instructions
Merge by code review.
Expected result
Unit tests on PostgreSQL 10 should pass.
Actual result
Unit tests cause an error on PostgreSQL >= 10:
1) JDatabaseDriverPostgresqlTest::testGetTableSequences
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
'column' => 'id'
- 'data_type' => 'bigint'
+ 'data_type' => 'integer'
'start_value' => '1'
'minimum_value' => '1'
- 'maximum_value' => '9223372036854775807'
+ 'maximum_value' => '2147483647'
'increment' => '1'
'cycle_option' => 'NO'
)
)
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
mbabker
- comment
- 2 Aug 2018
All the 3.x tests are still in this repo. It's only 4.0 that the tests live in one of ~45 repositories (between the ones for the CMS and the Framework packages).
wilsonge
- comment
- 6 Aug 2018
Unit tests still pass in travis and given this only affects unit tests merging this on review
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-06 09:34:58 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Now that unit tests have been moved.to their own repo is this the right place?