@wojsmol
@franz-wohlkoenig
@Magnytu2

I have made this PR to fix issue #21360

@ggppdk AFAIK you should only commit scss changes and tester should compile this to css. @dgrammatiko please confirm this

@wojsmol

a tester re-compiling is surely a good / proper thing

but PRs until now always included the updated CSS too
this because the template CSS files continue to be tracked,
thus you would not want them to be "stale" when the PR gets merged ... , right ?

I don't think that this PR makes a difference
#21217 (Remove vendor folders ?)

I don't think that this PR makes a difference
#21217 (Remove vendor folders ?)

Not #21217 php vendor but latests changes from @dgrammatiko for assets and because I'm not sure then I used "AFAIK" and ask for confirmation.

This solves nicely the main issue, which is that the second level menus do not display in present 4.0.
It also solves here #21353

I have tested this item ✅ successfully on 9919161

For now templates specifically are still committing the compiled CSS (as we have the discussion about where to move the uncompiled to - whether also to media or just the template dir) - hence the compiled files are still in the repository here.

@wilsonge does your Comment mean J4-PR can be tested by Patchtester?

@franz-wohlkoenig yes

@wojsmol all PR (as before npm-, ...-Changes)?

I have tested this item ✅ successfully on 9919161

Ready to Commit after two successful tests.

Thanks guys!

@franz-wohlkoenig See #21367 (comment) - for now changes in templates are don't requiring npm so good for patch tester.

@wojsmol thanks, so i will test Front- and Backend-PRs.

@franz-wohlkoenig I was not as precise as I wont:

• see https://github.com/joomla/joomla-cms/pull/21367/files - yhere are scss and css files- ok, for patch tester
• If as @infograf768 PR there is only scss or es6.js files - npm is requred.

if /files include *.css > Patchtester, correct?

https://github.com/joomla/joomla-cms/pull/21384/files have 1 php-File so not testable by Patchtester.

If PR has some files touched in media folder then it cannot be tested with patch tester

@ggppdk #21384 can be tested by Patchtester.

@franz-wohlkoenig In #21384 Files changed 6tam on github content o0nly *.php file so yes
@dgrammatiko Please update https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment with description when node.js is required to test PR.

That doc page is not for testing pull requests, it is a "how to get started once you git clone the repository" guide. Other documentation regarding pull requests should be updated instead to reflect the changes in 4.0.

@mbabker You are right that thus page is not a best place but for now I wont to have written this info somewhere.