? ? Pending

User tests: Successful: Unsuccessful:

avatar bene-we
bene-we
2 Aug 2018

New Pull Request for #11766

Summary of Changes

This pull request adds a new button inside the EditArticle view to create a corresponding menu item directly.

Testing Instructions

  1. Install patch / PR
  2. Go to Content > Articles
  3. Create a new article by clicking on New
    01 new article no button
    As you can see, the button is not available due to no new article is created
  4. Fill in the title and press Save
  5. The editing screen of the newly created article shows up and you are now able to create a new menu item with the button in the toolbar
    02 edit article new menu item button
  6. If you click the button, the modal opens
    03 new menu item modal
  7. Now set Menu Title, as Menu Item Type choose Single Article and select the new article
    04 set menu item title and article
  8. Click Save & Close and head to Menus > [The Menu with the new Item].
    You should see the new item in the list
    05 menu item created
  9. If the menu is connected to a menu module you should see it on the site as shown below
    06 article and menu item published on site

Added benefit: you can create any type of menu link

Expected result

The funcionality works as pointed out in the Testing Instructions section.

Actual result

At the moment there is not such a functionality

Documentation Changes Required

Yes, has been added to docs.joomla.org

avatar bene-we bene-we - open - 2 Aug 2018
avatar bene-we bene-we - change - 2 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2018
Category Administration com_content
avatar bene-we bene-we - change - 2 Aug 2018
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 2 Aug 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Aug 2018

I have tested this item successfully on 08daffd

System information

  • Nightly Build 4.0.0-alpha5-dev
  • Multilingual Sample Data (French, German DE, Persian)
  • Template: Cassiopeia
  • macOS Sierra, 10.13.6
  • Firefox 61 (64-bit)

CloudAccess.net

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Aug 2018

As this works only for Menu "Single Article": do you plan that Menu Item and Article are selected by Default?

avatar brianteeman
brianteeman - comment - 2 Aug 2018

@franz-wohlkoenig I don't understand your comment

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Aug 2018

After click on "New Menu Item" in Modal:

  • "Menu Item Type" is preselected by "Single Article"
  • "Select Article" is preselected by current Article.
avatar brianteeman
brianteeman - comment - 2 Aug 2018

ah - i understand you now. it would be useful but not essential

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Aug 2018

useful but not essential

true.

avatar brianteeman
brianteeman - comment - 2 Aug 2018

And thank you again for such a great pull request as your very first one

avatar brianteeman brianteeman - test_item - 2 Aug 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 2 Aug 2018

I have tested this item successfully on 08daffd

Works as described - great new feature

Probably will need updating in the near future when we have a replacement for bootstrap modals but for now its fine


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21357.

avatar SharkyKZ
SharkyKZ - comment - 2 Aug 2018

Without article being pre-selected, this is a shortcut to menu item form. Which is out of place both in terms of UI and code.

avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Aug 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Aug 2018

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 2 Aug 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 2 Aug 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-02 11:39:07
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Aug 2018
avatar wilsonge wilsonge - merge - 2 Aug 2018
avatar wilsonge
wilsonge - comment - 2 Aug 2018

Looks good to me

avatar bene-we bene-we - change - 2 Aug 2018
The description was changed
avatar bene-we bene-we - edited - 2 Aug 2018
avatar infograf768
infograf768 - comment - 3 Aug 2018

Bug. See PR #21391 for correction.

Add a Comment

Login with GitHub to post a comment