? Pending

User tests: Successful: Unsuccessful:

avatar priiish
priiish
1 Aug 2018

Pull Request for Issue # .

Summary of Changes

Changed the parameter in _canDeleteStates() => function call for _countItemsFromState().
It must be $table instead of $tableInfo.

Testing Instructions

*Create a state
*Select the state and try to delete it via the toolbar (trash button/icon)
*State will be moved to trash but you receive an error saying that the table does not exist

Expected result

Functions checks if state is "empty" (has no workflow associations). If that is the case it can be trashed.

Actual result

Error message due to wrong parameter usage. The query @ _countItemsFromState() doesn't properly work, therefore _canDeleteState() cannot check if state contains items (and should therefore not be deleted).

Documentation Changes Required

None.

avatar priiish priiish - open - 1 Aug 2018
avatar priiish priiish - change - 1 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2018
Category SQL Administration com_admin com_categories com_content com_menus com_messages
avatar brianteeman
brianteeman - comment - 1 Aug 2018

Pretty sure you didn't mean to commit all these changed files

avatar priiish
priiish - comment - 1 Aug 2018

No I did not, I'm sorry. My changes concern only joomla.php @ plugins / content / joomla.
I will revert this PR and create a more suitable one.

avatar priiish priiish - change - 1 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-01 11:50:58
Closed_By priiish
Labels Added: ?
avatar priiish priiish - close - 1 Aug 2018

Add a Comment

Login with GitHub to post a comment