User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Changed the parameter in _canDeleteStates() => function call for _countItemsFromState().
It must be $table instead of $tableInfo.
*Create a state
*Select the state and try to delete it via the toolbar (trash button/icon)
*State will be moved to trash but you receive an error saying that the table does not exist
Functions checks if state is "empty" (has no workflow associations). If that is the case it can be trashed.
Error message due to wrong parameter usage. The query @ _countItemsFromState() doesn't properly work, therefore _canDeleteState() cannot check if state contains items (and should therefore not be deleted).
None.
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin com_categories com_content com_menus com_messages |
No I did not, I'm sorry. My changes concern only joomla.php @ plugins / content / joomla.
I will revert this PR and create a more suitable one.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-01 11:50:58 |
Closed_By | ⇒ | priiish | |
Labels |
Added:
?
|
Pretty sure you didn't mean to commit all these changed files