[#21305] - Better code for class calling
- Fixed in Code Base
- 30 Jul 2018
- Medium
- Build: 4.0-dev
- # 21305
- Diff
- roland-d:revisit-21300-cmsobject-class
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
@roland-d i think there are similar improvements that can be made to
joomla-cms/libraries/src/Router/Router.php
Line 105 in e583418
In that specific case, no. The ::class magic constant refers to a fully qualified class name, in that specific case you're concatenating a string to build a class name.
In that case you should do __NAMESPACE__ . '\' . ucfirst($client) . 'Router' to transition that line of code from the global class name to the namespaced code (__NAMESPACE__ being a magic constant since PHP 5.3 to get the namespace of the current file, since we're referencing another class in the same namespace that works well here).
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-30 13:32:54 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on d72a089
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21305.