[#21293] - [4.0] Pagination [a11y] admin
- Fixed in Code Base
- 31 Jul 2018
- Medium
- Build: 4.0-dev
- # 21293
- Diff
- brianteeman:pag-ally1
User tests: Successful: Unsuccessful:
All current views with pagination in the administration have mistakenly had the pagination placed in the table footer. This is not correct as the table footer is only for use with summarising the data in the table.
This pr moves the pagination to immediately after the rendering of the table.
As a result we can also remove the column counts as we dont have a need for them (and they weren't used consistently anyway)
Confirmed by the a11y team @chmst @zwiastunsw
A future pr will look at restoring the a11y of the pagination itself which has been lost in the movee from j3
Testing
make sure pagination works as before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder com_installer com_languages |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21293.
all changes done and ok for more tests
I have retested categories, articles and menu-items but am a bit confused. As I see in the list of changed files, also the com_users view users is changed. But I do not see the changes for users in my repo. There I have still the < tfoot >.
I am using the patchtester for this test, because there are too many files for a manual action.
Are you using patchtester without authentication? There is a file limit which might be effecting you. go to the options of patchtester and set your github credentials
I've set the credentials. And repeated the fetch / apply. But the result is the same.
It does not make a difference for scuccessful test, but it is strange.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21293.
| Title |
|
||||||
Please check other files for unnecessary tabs. I can point them out individually if you want me to.
All the changes since the tests were just to remove some tabs on an empty line so this should be able to be set as RTC and merged
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit as stated above.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-31 11:17:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Great - now it's in the correct place I can do the PR to use the correct layout
I have tested this item✅ successfully on 678f36b
I have tested this item successfully om com_users view users, com_articles view articles and by inspecting the code.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21293.