? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
29 Jul 2018

Pull Request for Issue #17305

As info: I have written a plugin that adds JPagination navigation and an extended toc for specific articles in a similiar way like plg_content_pagebreak does but that listens to another tag/regex. Whenever there is no "system-pagebreak" marker inside an article plg_content_pagebreak throws a 404 then.

Summary of Changes

  • Remove exception that ignores that several use cases and extensions could use pagination or toc without "system-pagebreak" regexes. The exception was added with #11217
  • Set "Simple performance check" earlier.

Testing Instructions

  • See #17305 for cases where the exception creates annoying conflicts.
  • Apply patch and test again if any failures come up.

Expected result

Actual result

  • One have to deactivate plg_content_pagebreak to get no 404 or have to kick custom extensions that use Joomla features and standards (e.g. $page that comes from core).
  • The only way to get rid of this 404 is to add a senseless class="system-pagebreak to your custom extension tag or the article text before plg_content_pagebreak works. Bad practice. [EDIT: That's a stupid idea because plg_content_pagebreak then throws another exception. I don't understand at all why this plugin has to throw 404 exceptions.]
avatar ReLater ReLater - open - 29 Jul 2018
avatar ReLater ReLater - change - 29 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2018
Category Front End Plugins
avatar ReLater ReLater - change - 29 Jul 2018
The description was changed
avatar ReLater ReLater - edited - 29 Jul 2018
avatar ReLater
ReLater - comment - 29 Jul 2018

Closed because doesn't fix the problem. 404 comes from elsewhere.

Reopened. I've made an error during tests.

avatar ReLater ReLater - change - 29 Jul 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-07-29 01:33:18
Closed_By ReLater
Labels Added: ?
avatar ReLater ReLater - close - 29 Jul 2018
avatar ReLater ReLater - change - 29 Jul 2018
Status Closed New
Closed_Date 2018-07-29 01:33:18
Closed_By ReLater
avatar ReLater ReLater - change - 29 Jul 2018
Status New Pending
avatar ReLater ReLater - reopen - 29 Jul 2018
avatar ReLater ReLater - change - 29 Jul 2018
The description was changed
avatar ReLater ReLater - edited - 29 Jul 2018
avatar ReLater ReLater - change - 29 Jul 2018
The description was changed
avatar ReLater ReLater - edited - 29 Jul 2018
avatar ReLater ReLater - change - 29 Jul 2018
The description was changed
avatar ReLater ReLater - edited - 29 Jul 2018
avatar ReLater ReLater - change - 29 Jul 2018
The description was changed
avatar ReLater ReLater - edited - 29 Jul 2018
avatar ReLater ReLater - change - 29 Jul 2018
The description was changed
avatar ReLater ReLater - edited - 29 Jul 2018
avatar SharkyKZ
SharkyKZ - comment - 29 Jul 2018

? Based on #17305 description, the issue is with invalid custom code.

avatar ReLater ReLater - change - 24 Sep 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-09-24 10:36:43
Closed_By ReLater
avatar ReLater ReLater - close - 24 Sep 2018

Add a Comment

Login with GitHub to post a comment