? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
28 Jul 2018

Summary of Changes

The platform bootstrap was registering the old form entity paths but that is no longer necessary because the paths no longer exist.

Additionally, the form helper was default registering path lookups based on the original coding without namespace or autoload support. This behavior is actually now entirely unnecessary as all core form entities are autoloaded, so this path registration is dropped.

Testing Instructions

CMS, especially views with forms, still functions.

avatar mbabker mbabker - open - 28 Jul 2018
avatar mbabker mbabker - change - 28 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2018
Category Libraries
avatar wilsonge wilsonge - close - 31 Jul 2018
avatar wilsonge wilsonge - merge - 31 Jul 2018
avatar wilsonge wilsonge - change - 31 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-31 14:15:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 31 Jul 2018

Adding docs required here as we should document we're no longer automatically pluralising the paths

avatar mbabker
mbabker - comment - 31 Jul 2018

That pluralization was only for the libraries/joomla/form/(fields|rules) paths. Which is not necessary at all with autoloading. The pluralization logic still exists in MVC. So if anything, the documentation simply reads "the libraries/joomla/form/fields and libraries/joomla/form/rules directories are no longer registered to find form classes, all form classes should be autoloaded instead".

Add a Comment

Login with GitHub to post a comment