J4 Issue No Code Attached Yet Release Blocker
avatar mbabker
mbabker
28 Jul 2018

Following #21217 the logic to create patch packages and our existing workflows no longer works for the libraries/vendor and media/vendor directories to determine which files have been added, modified, or deleted between patch releases or to determine which files have been deleted since a git tag. This workflow will need to be addressed before a stable release can be created.

avatar mbabker mbabker - open - 28 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2018
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 28 Jul 2018
avatar mbabker mbabker - change - 28 Jul 2018
Labels Added: ?
avatar mbabker mbabker - labeled - 28 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Jul 2018
Category Repository
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Jul 2018
Status New Discussion
avatar brianteeman brianteeman - change - 30 Jul 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 30 Jul 2018
avatar wilsonge
wilsonge - comment - 4 Dec 2018

So me and Michael discussed this offline a bit. Probably this is going to have to be a generated list of files (where we run the build tag to remove things like node_modules and build dirs after package generation) and then generate a file.

Options are the store the list of files from each release in the build directory, OR we can store them in some sort of jenkins artifact reference (https://jenkins.io/doc/pipeline/tour/tests-and-artifacts/) in the jenkins job.

Ideally we don't want to make jenkins do a "double/triple" npm build (one for the new release and one for each previous release with zipped upgrade path) as this will add significant time to the release job.

avatar Quy Quy - change - 1 Oct 2019
Labels Added: ? ?
avatar Quy Quy - labeled - 1 Oct 2019
avatar Quy Quy - change - 1 Oct 2019
Labels Added: PBF
avatar Quy Quy - labeled - 1 Oct 2019
avatar alikon alikon - change - 24 Jan 2020
Labels Removed: ? PBF
avatar alikon alikon - unlabeled - 24 Jan 2020
avatar alikon alikon - unlabeled - 24 Jan 2020
avatar wilsonge
wilsonge - comment - 1 Apr 2020

WIP PR is at #25559 but fixes would be appreciated to try and prevent the double/triple build problems mentioned

Add a Comment

Login with GitHub to post a comment