[#21262] - [4.0] installer plugin detection
- Closed
- 16 Jun 2019
- Medium
- Build: 4.0-dev
- # 21262
- Diff
- barbarosuntorunu:20608-installerPluginDetection
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Installer Plugin Detection (Joomla4) #20608
Summary of Changes
FIRST STEP
(Joomla 3) We have four Plugins Installers:
1)Install From WEB
2)Install From Upload
3)Install From Folder
4)Install From URL
But System did not declera to 'Install From WEB'. When we had just sellected the 'Install From WEB', system give warning message:
SECOND STEP
(Joomla 4) When we disable these four plugins, System gave us error table:
Testing Instructions
FIRST STEP
We disabled 'Install from Upload', 'Install from Folder', 'Install from URL'.
Extensions---->>Plugins--->Select Type--->Installer
When we control the way, we had warning.
Extensions---->>Manage--->>Install
SECOND STEP
We disabled all installer plugins.
System--->>Manage-->>Plugins-->>Table Options--->>Select Type--->>Installer
We had warning table because of disabled installer plugins.
System--->>Install--->>Extensions
Actual result
FIRST STEP
Before Solve:
After Solve:
SECOND STEP
(Before Solve):
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_installer |
| Labels |
Added:
?
|
||
a bit confused by your comment about having to install the install from web plugin
it is installed by default in joomla 4
@brianteeman line 41 is $active = ''; so it can not generate this notice.
Can you please check if the PR is applied correctly?
@barbarosuntorunu sorry that was a silly unrelated issue from me
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21262.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21262.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Can you fix conflicts please.
Conflicts are still there ;-)
| Title |
|
||||||
| Title |
|
||||||
@barbarosuntorunu Thank you for the pull, request, can you fix the merge conflicts?
| Closed_By | Quy | ⇒ | joomla-cms-bot |
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-16 17:33:25 |
| Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/21262
Replaced by PR #25238.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21262.
With no plugins enabled i getNotice: Undefined offset: 0 in C:\htdocs\cms4\administrator\components\com_installer\tmpl\install\default.php on line 41