[#21236] - 3.9 HTMLHelper stylesheet method
- Closed
- 23 Jul 2018
- Medium
- Build: staging
- # 21236
- Diff
- joomla:3.9-dev
- Success continuous-integration/drone/push the build was successful Details
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Failure continuous-integration/appveyor/branch AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #21216 .
Summary of Changes
In ./libraries/src/HTML/HTMLHelper.php at line 610 it writes:
if (!is_array($attribs))
but should better be
if (!is_array($attribs) || !is_array($options))
Reason
An old extension adding stylesheets the (very) old way like
JHTML::stylesheet('filename','path-to-file');
will obviously not add the stylesheet but still create several "illegal string offset" notices instead of better eventually add a deprecated message to flog
In Joomla4 it is also, but on line 699 (alpha3) or line 675 (alpha4) ... is a seperate PR required for this?
| Status | New | ⇒ | Pending |
| Category | ⇒ | Repository SQL Administration com_admin Postgresql MS SQL com_banners com_categories com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-23 16:42:13 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/21236
Closed as stated above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21236.
| Category | Repository SQL Administration com_admin Postgresql MS SQL com_banners com_categories com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages | ⇒ | Administration com_categories com_contact com_content com_menus com_newsfeeds Language & Strings Libraries Modules Front End |
@FoTo50 This PR is invalid as you trying merge 3.9-dev branch to staging.
@franz-wohlkoenig Please close this PR.