I am creating this as a new issue instead of it being on each of the open pr for custom elements as it effects them all.
When testing the custom elements there are several accessibility issues identified
Looking at the following video from google and the associated examples it is clear to see that there are quite a lot of changes that need to be made to all the custom elements that are being used in j4 to make sure they are accessible and standards compliant. (This includes the custom elements already merged and all future elements)
Unfortunately as this is all js I can't help with writing fixes I can just point out the issue and stress the severity of it.
From my understanding of this it is not correct to just have the field in the custom element. The label must be in the custom element as well
https://www.youtube.com/watch?v=7a6bLXw2lqQ
https://developers.google.com/web/fundamentals/web-components/examples/
Labels |
Added:
?
?
|
so it may be irrelevant but it oesn't get around the fact that we do have the problems described
Category | ⇒ | Accessibility |
Status | New | ⇒ | Discussion |
Can we please just use already existing custom elements that work instead of trying and failing to write our own.
@brianteeman you have any suggestions?
The only requirement we have is to not have any dependencies
why not? there are plenty of dependencies already in joomla
He basically means "no hard jQuery or UI framework (Bootstrap) dependencies".
Labels |
Added:
J4 Issue
|
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-08 13:17:44 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
?
Removed: ? |
Labels |
Removed:
?
|
The video is irrelevant as none of our custom elements is hiding the contents into the shadow DOM.