[#21204] - [4.0] update the custom elements
- Fixed in Code Base
- 3 Aug 2018
- Medium
- Build: 4.0-dev
- # 21204
- Diff
- dgrammatiko:4.0-dev-update-ce
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- update webcomponentjs (the polyfills) to the latest version (2.0.3)
- remove the hacked tabs custom element from media/system/webcomponents
- Fix the two known bugs for tabs (appendChild instead of append and tabs.id instead of tabs.hash)
Testing Instructions
Apply patch (probably won't work with patchtester)
Edit an article
Check the tabs functionality
Save Check the alert element
exit and re-edit the same article, observe that the tabstate is kept
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Layout Libraries JavaScript |
Tested in chrome - all good
Tested in IE11 - the tabs are present now BUT now the editor doesnt load
: Unable to get property 'nodeName' of undefined or null reference in tinymce.min.js
I have tested on firefox 61.0.1 (64-Bit) on Ubuntu 18.04
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21204.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21204.
@dgrammatiko Few things I noticed
-
The issue still present.
-
In debug mode why its loading
.min.jsfiles ?
-
Is these custom elements are not a part of joomla ?
Because, these are kept inmedia/vendor?
@dgrammatiko As I can see.
If you test this on Article in your test case. It's working fine. Because Its going through first case
this.hasNested is true for the article.
that's why its giving output in the console.
And, in mine case, I tested at com_templates and it's going through 2nd case else .
Tested in IE11 - the tabs are present now BUT now the editor doesnt load
Well, Houston we have a problem. I'm trying to figure out why this is happening
@Anu1601CS probably the conditional is wrong, will take a look at that once I fix the polyfills situation, which is way more severe
@dgrammatiko Ok, Thanks
FWIW I've already filled an issue: tinymce/tinymce#4502 as all the combinations of the polyfills that include the shadowDOM will fail. This is a tinyMCE issue
About the tinyMCE problem: it's gonna be fixed upstream.
tinymce/tinymce#4502 (comment)
@brianteeman asked me to look here.
I'm pretty new to Joomla development - I've got it running locally, but the JS files loaded by the browser are all minified versions. Is there a way to get Joomla to use the original versions?
Change to debug mode in the Joomla configuration.
| Labels |
Added:
?
|
||
| Category | Repository Layout Libraries JavaScript | ⇒ | Repository Layout Libraries |
I have tested this item
All tested fine.
We recover the tabs (yes, including in Firefox) although their display have changed (certainly a matter of css)
Did not test with IE as I use mac.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21204.
@Anu1601CS can you please retest?
Needs npm to be tested
npm = ?
npm = Node Package Manager
@franz-wohlkoenig In simple words - needs a little knowledge about you Mac Terminal. Can be referred also as node or nodee.js
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-03 09:57:20 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 56722dc
Before and after I applied the patch I could edit an article and if I check the tabs functionality everything was OK.
I closed and re-edit the same article - the tabstate is kept.
I spotted that the file /media/vendor/joomla-custom-elements/js/joomla-tab.js should not be minimized. And it would be great if you could explain why this files for joomla-tab are in the folder /media/vendor/joomla-custom-elements/js and not in the folder /media/system/webcomponents/js
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21204.