[#21202] - [4.0] Change css rule
- Closed
- 22 Jul 2018
- Medium
- Build: 4.0-dev
- # 21202
- Diff
- brianteeman:button
User tests: Successful: Unsuccessful:
Since the change to use custom elements for toolbar buttons we are still left with some toolbar buttons that are not using custom elements eg the batch button
All buttons in the toolbar (custom elements and old style) have a margin-left of 0.75rem
Except for the first occurrence of the old style button which had a margin-left of 0. As that first occurrence may now no longer occur at the beginning of the row it results in two buttons without a margin between them. (see image)
This quick pr deletes that first occurrence rule so that we have the space again (see image)
This pr changes the class from first-of-type to first-child
Any comment about why the batch is not a custom element is beyond the scope of this pr
before
after
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
The side effect is extra left padding on the first button.
Before:
After:
:(
need to find a different css rule then
Replacing :first-of-type with :first-child
should work, as we want to target the first child of the toolbar
as browser support is since IE7
can we try the above ?
| Labels |
Added:
?
|
||
Changed from removing the first of type to replacing it with first-child
| Title |
|
||||||
Description updated
There is an extra problem that maybe is not directly related to this PR
RTL seem to load sames same CSS as LTR
we have (LTR):
.subhead .btn-toolbar > :first-of-type {
margin-right: 0;
}
.subhead .btn-toolbar > * {
margin-right: .75rem;
margin-left: 0;
}For RTL it should be:
.subhead .btn-toolbar > :first-of-type {
margin-left: 0;
}
.subhead .btn-toolbar > * {
margin-left: .75rem;
margin-right: 0;
}If it should not be done in this PR then please tell me
and i will mark a successful PR as i have tested already and it works
I have tested this item
Test without RTL.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21202.
This one has to be redone after this merge: #21206 and this comment
#21202 (comment)
@ggppdk
For RTL one has also to edit the template-rtl.scss
with this
diff --git a/administrator/templates/atum/scss/template-rtl.scss b/administrator/templates/atum/scss/template-rtl.scss
index 3bb0cde..be2a28e 100644
--- a/administrator/templates/atum/scss/template-rtl.scss
+++ b/administrator/templates/atum/scss/template-rtl.scss
@@ -176,5 +176,5 @@
margin-left: 0;
- &:first-of-type {
+ &:first-child {
margin-right: 0;
}
and then we will get in template-rtl.css
.subhead .btn-toolbar > * {
margin-right: .75rem;
margin-left: 0; }
.subhead .btn-toolbar > *:first-child {
margin-right: 0; }
Result:
| Category | Administration Templates (admin) | ⇒ | Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder |
closing this as something went wrong with resolving conflicts - will redo
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-22 11:40:36 |
| Closed_By | ⇒ | brianteeman |
I have tested this item✅ successfully on a3e559a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21202.