[#21199] - [4.0] Notices when uninstalling a language pack
- Fixed in Code Base
- 20 Jul 2018
- Medium
- Build: 4.0-dev
- # 21199
- Diff
- wilsonge:fix/language-uninstall
User tests: Successful: Unsuccessful:
Pull Request for Issue #21153 .
Summary of Changes
Fix some undefined variables in the installer
Testing Instructions
Install a language pack (German, French or Persian are available through Install Languages)
Then go to Extensions : Manage and uninstall the pack
Expected result
Pack is correctly uninstalled.
Notices in php logs
Actual result
[17-Jul-2018 07:27:54 Europe/Berlin] PHP Notice: Undefined variable: element in /Applications/MAMP/htdocs/installmulti/joomla40/libraries/src/Installer/Adapter/LanguageAdapter.php on line 122
[17-Jul-2018 07:27:54 Europe/Berlin] PHP Notice: Undefined variable: element in /Applications/MAMP/htdocs/installmulti/joomla40/libraries/src/Installer/Adapter/LanguageAdapter.php on line 122
[17-Jul-2018 07:27:54 Europe/Berlin] PHP Notice: Undefined variable: error in /Applications/MAMP/htdocs/installmulti/joomla40/libraries/src/Installer/Adapter/PackageAdapter.php on line 445
Note these variables won't show on screen because of the redirect - you'll need to either add breakpoints or check your php error log
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21199.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21199.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-20 18:04:22 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Nice.
I have tested this item✅ successfully on a0895d6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21199.