User tests: Successful: Unsuccessful:
This is a clear example of something that should be a button and not an "a" styled as a button.
In some cases it is ok to add a role=button to an "a" but there is one issue with that technique - an "a" only responds to an enter key. a button responds to an enter and a space. So if you use an "a" you have to add something to monitor the space. (http://www.last-child.com/keyboard-accessibility-with-the-space-bar/)
In this specific case it is super easy to change from an "a" to a "button"
To test make sure the toggle editor button still works. You can also test if it can be activated by tabbing to it and then selecting with either the space or the enter keys.
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-20 11:13:53 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
thanks - baby steps
Thanks!