? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Jul 2018

This is a clear example of something that should be a button and not an "a" styled as a button.

In some cases it is ok to add a role=button to an "a" but there is one issue with that technique - an "a" only responds to an enter key. a button responds to an enter and a space. So if you use an "a" you have to add something to monitor the space. (http://www.last-child.com/keyboard-accessibility-with-the-space-bar/)

In this specific case it is super easy to change from an "a" to a "button"

To test make sure the toggle editor button still works. You can also test if it can be activated by tabbing to it and then selecting with either the space or the enter keys.

avatar brianteeman brianteeman - open - 20 Jul 2018
avatar brianteeman brianteeman - change - 20 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2018
Category Layout
avatar wilsonge wilsonge - change - 20 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-20 11:13:53
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 20 Jul 2018
avatar wilsonge wilsonge - merge - 20 Jul 2018
avatar wilsonge
wilsonge - comment - 20 Jul 2018

Thanks!

avatar brianteeman
brianteeman - comment - 20 Jul 2018

thanks - baby steps

Add a Comment

Login with GitHub to post a comment