Joomla! Issue Tracker | Joomla! CMS #21188 - Remove if/else in user debug models that can never hit else conditions

Fixed in Code Base
20 Jul 2018
Medium
Build: staging
# 21188
mbabker:wow-debugging-has-some-interesting-behavior

mbabker
20 Jul 2018

Summary of Changes

Once upon a time, the debug user and debug group views were short circuited to be able to skip access checks for certain levels of the ACL tree. However, since the commit for JoomlaCode item 22868 this short circuiting was broken because the arrays that are being processed went from an array of action name and level to action name and description.

So, when you actually get to the part of the models that is changed here, essentially you're doing an if check on "is the ACL tree level greater than or equal to zero" (code example: https://3v4l.org/7Pprh). Unless your #__assets table is a level beyond FUBAR than anything I've ever seen, this condition is always going to be true. Therefore, we can remove the dead code.