? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 Jul 2018

Update the pages found at system -> information -> system information to ensure that we have scope for each row and column

avatar brianteeman brianteeman - open - 19 Jul 2018
avatar brianteeman brianteeman - change - 19 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jul 2018
Category Administration com_admin
4fdddc7 19 Jul 2018 avatar brianteeman oops
avatar brianteeman brianteeman - change - 19 Jul 2018
Labels Added: ?
avatar brianteeman brianteeman - change - 19 Jul 2018
Title
[4.0] System information pages
[4.0] [a11y] System information pages
avatar brianteeman brianteeman - edited - 19 Jul 2018
avatar Quy Quy - test_item - 19 Jul 2018 - Tested successfully
avatar Quy
Quy - comment - 19 Jul 2018

I have tested this item successfully on 4fdddc7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21186.

avatar zwiastunsw
zwiastunsw - comment - 20 Jul 2018

What is the reason for these changes?
These are simple tables. The scope attributes are redundant here. The marking of the header cells in the columns shall be sufficient

avatar brianteeman
brianteeman - comment - 20 Jul 2018

it can always be said to be sufficient but this is more explicit

avatar brianteeman
brianteeman - comment - 20 Jul 2018

Also if we want to encourage best practices so that developers use scope it is simpler if we do it everywhere and not just when someone has made an arbitrary decision that its not a simple table. From experience I can say that if this "simple" table doesnt get the scope update now it wont be long before someone either creates an issue or submits a pull request to "fix" it

avatar zwiastunsw zwiastunsw - test_item - 20 Jul 2018 - Tested successfully
avatar zwiastunsw
zwiastunsw - comment - 20 Jul 2018

I have tested this item successfully on 4fdddc7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21186.

avatar Quy Quy - change - 20 Jul 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Jul 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21186.

avatar wilsonge wilsonge - change - 21 Jul 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-21 23:28:39
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 21 Jul 2018
avatar wilsonge wilsonge - merge - 21 Jul 2018
avatar wilsonge
wilsonge - comment - 21 Jul 2018

Thanks!

avatar brianteeman
brianteeman - comment - 21 Jul 2018

Thanks

Add a Comment

Login with GitHub to post a comment