I have tested this item ? unsuccessfully on 089aec4

Same Behaviour using PR as described in #21142, test on Template > Styles.

System information

• Nightly Build 4.0.0-alpha4-dev
• Multilingual Sample Data
• Template: Cassiopeia
• macOS Sierra, 10.13.6
• Firefox 61 (64-bit)

CloudAccess.net

• PHP 7.1.15
• MySQLi 5.7.18-cll-lve

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21183.}

Please undo the changes in the js

I have tested this item red_circle unsuccessfully on 089aec4

Same Behaviour using PR as described in #21142, test on Template > Styles.

System information
Nightly Build 4.0.0-alpha4-dev
Multilingual Sample Data
Template: Cassiopeia
macOS Sierra, 10.13.6
Firefox 61 (64-bit)
CloudAccess.net
PHP 7.1.15
MySQLi 5.7.18-cll-lve

@franz-wohlkoenig
Yes, this is an expected behaviour because code is not using new tab function.

Please undo the changes in the js

@dgrammatiko I reverted the changes in js
After this, I am getting the same issue.

@dgrammatiko I changes the code here.

To like this

Then it works fine for me.
Because, tab.hash is undefined. We want id of tab right ?

@franz-wohlkoenig You can follow this.

1. Open the System Menü and click on Site Templates

2. Click on
   

3. Change tab to Created Overrides and reload page.

@Anu1601CS the code is not in this repo, it is in https://github.com/joomla-projects/custom-elements

We just copy this to the main repo because it was easier when we were working with the backend template.
Essentially if you change something here will be lost when we switch to the normal, custom elements repo.

@dgrammatiko Ok, should i close this ?
And, make a PR in
https://github.com/joomla-projects/custom-elements

@Anu1601CS Yes, that is how I interpreted his comment.

No this pr right now is fine

@Anu1601CS i was following Description in #21142 as the Test Instructions wasn't clear for me.

Will try again.

Following Instructions on #21183 (comment) got:

@franz-wohlkoenig No, right now this change is fine as @dgrammatiko commented.
Because we have work to change bootstrap.startTabSet to uitab.startTabSet as per our new code.

I have tested this item ✅ successfully on f71268c

#21183 (comment)
@franz-wohlkoenig Yes, this is an issue right now. So, we have to fix in main custom elements repo here https://github.com/joomla-projects/custom-elements

Then, this issue going to fix.
I would suggest you to reopen this issue. #21142

#21142 reopened as stated above.

I have tested this item ✅ successfully on dae854f

I checked out this branch and I could see the new uitab. As only the file administrator/components/com_templates/tmpl/template/default.php is changed that's what I expected.

After refreshing I saw the content of all tabs on the page (among themselves). That should be changed.

After refreshing I saw the content of all tabs on the page (among themselves). That should be changed.

what do you mean? The content is available before the js has been executed, this is normal. Hiding it is a huge problem for SEO!

@dgrammatiko

what do you mean? The content is available before the js has been executed, this is normal. Hiding it is a huge problem for SEO!

I mean that I see all content like you see in the attached picture. I only expect to see the content of the current tab. But I think we have to handle this via javascript int the the file /media/system/webcomponents/js/joomla-tab.js , right?

@astridx all the tabs are active as far as i can see, that's why you see all the tabs

This tabs bug will be fixed shortly

This tabs bug will be fixed shortly

@dgrammatiko Thank you for confirming. I marked the test as successful because I assumed that this is just about switching to the new ui tabs. I just wanted to say that the view is not quite correct yet.

please test #21204

What's the status here?

@laoneo We will wait until #21204 get merge to the core.

#21204 is merged now.

@dgrammatiko Is tab issue fixed?

@Anu1601CS I have no clue, I added the part for the id, is there something else broken?

@dgrammatiko Yes, I think here https://github.com/joomla-projects/custom-elements/blob/563e8c4e36038bcd3723720f6903adb9b34110ac/src/js/tab/tab.js#L104

It always gives -1 . So, if we set if (tabLinkHash.indexOf(theId) === -1) Then, it works fine.

Closed - nothing left to do here and I created a pr for the js joomla-projects/custom-elements#106