? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
18 Jul 2018

Pull Request for Issue #21110

Summary of Changes

Fixes the table names

Testing Instructions

See #21110 - no longer errors

avatar wilsonge wilsonge - open - 18 Jul 2018
avatar wilsonge wilsonge - change - 18 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2018
Category Administration com_contact com_newsfeeds
avatar wilsonge wilsonge - change - 18 Jul 2018
Title
Fix invalid table names in assocations
[4.0] Fix invalid table names in assocations
avatar wilsonge wilsonge - edited - 18 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 18 Jul 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Jul 2018

I have tested this item successfully on bb3443a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21171.

avatar infograf768
infograf768 - comment - 18 Jul 2018

I do not have the Notices anymore (Nice) but some weird behavior in the side by side page.

here is a screenshot for 2 articles (Already associated)
screen shot 2018-07-18 at 13 10 18

Here for 2 contacts.
remark the tabs are changed to buttons (that may be a template issue) but also the fact that the association is not displayed which is a bug.
screen shot 2018-07-18 at 13 12 20

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Jul 2018

have seen Buttons but thought out of Scope of this PR.

avatar wilsonge
wilsonge - comment - 18 Jul 2018

The tabs collapse into an accordion style format on smaller screen resolutions. so i think that's good.

avatar wilsonge wilsonge - close - 18 Jul 2018
avatar wilsonge wilsonge - merge - 18 Jul 2018
avatar wilsonge wilsonge - change - 18 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-18 12:34:00
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 18 Jul 2018

Merging this to allow progress. Most of the rest of the issues are javascript ones which aren't my strong suit :P

avatar wilsonge
wilsonge - comment - 18 Jul 2018

@infograf768 fwiw

screen shot 2018-07-18 at 18 08 49

Right now in dev the association doesn't display either - so I don't think that's a 4.x bug

The change target button is broken in 4.x though - I've asked Dimitris to look into that

avatar infograf768
infograf768 - comment - 18 Jul 2018

Right now in dev the association doesn't display either

you mean in 3.x ?

avatar infograf768
infograf768 - comment - 18 Jul 2018

The tabs collapse into an accordion style format on smaller screen resolutions. so i think that's good.

no problem with that. The issue is that we have a different display for menu items, articles and caregories.

avatar wilsonge
wilsonge - comment - 18 Jul 2018

you mean in 3.x ?

Yes (see screenshot)

no problem with that. The issue is that we have a different display for menu items, articles and caregories.

I think @dgt41 implemented the custom element tabs in articles and categories only right now (also media manager - but obviously that's not covered by associations) - so I'd expect those two to be different to the rest right now. That's a WIP that will get standardised one way or another

avatar infograf768
infograf768 - comment - 19 Jul 2018

you mean in 3.x ?

Yes (see screenshot)

GRRR, same for newsfeeds.... We have to solve that. Also in 3.x

avatar infograf768
infograf768 - comment - 19 Jul 2018

Created issue
#21178

avatar infograf768
infograf768 - comment - 19 Jul 2018

and patch for 3.x
#21180

Add a Comment

Login with GitHub to post a comment