? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 Jul 2018

Patch similar to #21141

Summary of Changes

Correcting alternate urls.
Route is much stricter in 4.0. Getting twice lang in the url, i.e.$lang=xx-XX&lang=xx breaks routing.

Testing Instructions

Create a multilingual site with the multilingual sample data.
Make sure sef is on.
Homes are category menu items per default.
Create 1 article in each language and associate them.
Create single article menu items for these 2 articles and DO NOT associate them.
In front end load one of the articles menu items.
Look at source.

Before patch

my single article menu items aliases are
modules-fr-fr and modules-en-gb

<link href="http://localhost:8888/installmulti/joomla40/index.php/fr?view=article&amp;id=13&amp;catid=12" rel="alternate" hreflang="fr-FR">
<link href="http://localhost:8888/installmulti/joomla40/index.php/en/modules-en-gb" rel="alternate" hreflang="en-GB">

After patch

<link href="http://localhost:8888/installmulti/joomla40/index.php/fr/modules-fr-fr" rel="alternate" hreflang="fr-FR">
<link href="http://localhost:8888/installmulti/joomla40/index.php/en/modules-en-gb" rel="alternate" hreflang="en-GB">

@franz-wohlkoenig @wilsonge @laoneo

Documentation Changes Required

None.

avatar infograf768 infograf768 - open - 17 Jul 2018
avatar infograf768 infograf768 - change - 17 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2018
Category Front End Plugins
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Jul 2018

Create single article menu items for these 2 articles and DO NOT associate them.

By Default one Article for each Language is installed and associated.

So you mean create a

  • second Article in each Language but not associate them
  • new Menu Item "Single Article" for each Language

and test like described above ("In front end load one of the articles menu items. Look at source").

avatar infograf768
infograf768 - comment - 17 Jul 2018

second Article in each Language but not associate them

no.
create the new articles AND associate them.
create single article menu items and Do NOT associate them

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 17 Jul 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Jul 2018

I have tested this item successfully on 8cf265c

Without Patch

screen shot 2018-07-17 at 12 58 19

With Patch

screen shot 2018-07-17 at 12 59 50


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21154.
avatar infograf768
infograf768 - comment - 17 Jul 2018

One more tester. @wilsonge ?

avatar wilsonge wilsonge - test_item - 17 Jul 2018 - Tested successfully
avatar wilsonge
wilsonge - comment - 17 Jul 2018

I have tested this item successfully on 8cf265c

Works for me on newsfeed associations


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21154.

avatar wilsonge wilsonge - change - 17 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-17 12:20:55
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 17 Jul 2018
avatar wilsonge wilsonge - merge - 17 Jul 2018
avatar wilsonge
wilsonge - comment - 17 Jul 2018

Thanks JM!

Add a Comment

Login with GitHub to post a comment