[#21147] - [4.0] Fix hard coded class attribute in select.groupedlist, also causing invalid HTML markup
- Closed
- 28 Jul 2018
- Medium
- Build: 4.0-dev
- # 21147
- Diff
- ggppdk:patch-65
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Remove hard coded class attribute from JHtml('select.groupedlist', ...
Testing Instructions
Code review
Expected result
Hard coded class attribute for select.groupedlist does not exist
Actual result
Hard coded class attribute for select.groupedlist exists
Why remove it ?
- it is hard coded
- it causes invalid HTML when given custom class attribute
- it does not exist in J3
- it does not exist for select.list , not even in J4
If anyone suggests to add it as a default value , yes it is easy, but i will not do it, because it is rather wrong
no reason to introduce a hard code styling in the library that is
- neither really needed,
- nor is J4 yet released to call it a B/C break or similar
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
@franz-wohlkoenig It seems this PR here is closed in GitHub but pending in the issue tracker. Can you check and if necessary (means you see the same as I do) fix the tracker status?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21147.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-28 07:55:48 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/21147
@richard67 thanks for Hint, PR is now closed at Issue Tracker too.
Duplicate. Please test PR #20196