? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
16 Jul 2018

Pull Request for Issue #21132

Summary of Changes

Route is much stricter in 4.0. Getting twice lang in the url, i.e.$lang=xx-XX&lang=xx breaks routing.

Testing Instructions

Create a multilingual site with the multilingual sample data.
Make sure sef is on. Tested here with url rewriting.
Homes are category menu items per default.
Load frontend home and switch language via the language switcher.

Before patch

We should get urls of type
whatever/fr
whatever/en

Actual result

We get
/en?view=category&id=8
and
/fr?view=category&id=9

Also, If some article are associated and we have 2 not associated single menu items
The switcher flag for the language in use gives correctly
/en/modules-en-gb
but when switching to the other language, we get
/fr?view=article&id=13&catid=12

After patch

Urls are correctly displaying.

Note: we can't test now for Contacts as we have multiple errors, but it can be tested for single associated newsfeeds (their menu items NOT associated) AFTER merging #21140 OR using last instance of 4-0-dev (not nightly build).

For Newsfeeds categories as well as for Contacts categories, we have a fatal error (Cannot redeclare class) and therefore can't test.

@laoneo @franz-wohlkoenig

avatar infograf768 infograf768 - open - 16 Jul 2018
avatar infograf768 infograf768 - change - 16 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2018
Category Modules Front End
avatar infograf768
infograf768 - comment - 16 Jul 2018

Supplementary Note

We may need to do the same correction in the languagefilter. Needs other tests.

avatar infograf768 infograf768 - change - 16 Jul 2018
The description was changed
avatar infograf768 infograf768 - edited - 16 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 16 Jul 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jul 2018

I have tested this item successfully on 9a86186


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21141.

avatar wilsonge wilsonge - change - 16 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-16 11:10:25
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 16 Jul 2018
avatar wilsonge wilsonge - merge - 16 Jul 2018
avatar wilsonge
wilsonge - comment - 16 Jul 2018

I also tested this before merging. Works well :)

avatar infograf768
infograf768 - comment - 16 Jul 2018

I will modify also in languagefilter as we have the same issue for alternate links.
After siesta.

Add a Comment

Login with GitHub to post a comment