[#21136] - [4.0] Improve Menu/Toolbar RTL in atum
- Fixed in Code Base
- 16 Jul 2018
- Medium
- Build: 4.0-dev
- # 21136
- Diff
- wilsonge:feature/rtl-atum
User tests: Successful: Unsuccessful:
Improves the menu (text is now on the right not left of the menu), and the toolbar (things now render semi-correctly). The table options drop down also now opens correctly below the dropdown
@ciar4n please review me trying to implement CSS - I'm sure its dreadful in more than one way :)
Test by installing the Persian Language Pack
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
Not needed and pushing menu out form edge of viewport
Change to right: 60px for correct position of sub menu
As mentioned by @infograf768, remove the following... https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/template-rtl.scss#L111-L113
Change to right: 60px for correct position of sub menu
Ahh that's the one I was looking for but couldn't find :) Thanks!
I've also simplified down the toolbar a bit more. So with these corrections. Any objections to merging this? It's far from perfect but much better than before :P
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21136.
One last bug fix for the top menu
If you can, let's also correct this
.mr-2, .mx-2 {
margin-right: .5rem !important;
}
Normally if I understand well scss
it should be in LTR
.mr-2,
.mx-2 {
margin-right: 0.5rem !important; }
margin-left: 0;
}
and in RTL
.mr-2,
.mx-2 {
margin-right: 0;
margin-left: .5rem !important;
}
@infograf768 Which view is this in?
Don't worry - found it and done
| Title |
|
||||||
Articles manager
I have tested this item
Good to go for now. Solves a lot of stuff. If we find something missing, we can add issue later.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21136.
@franz-wohlkoenig can you also retest please.
@infograf768 this for another Issue?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-16 15:54:10 |
| Closed_By | ⇒ | wilsonge |
Yah there's a huge amount more to do here. But let's take it one step at a time :)
Note: for the cpanel
.flex-grow-1 is missing a text-align: right;
.list-group is also missing text-align: right;
Don't add it to flex-grow-1. This class instructs the element to fill available space and will do so regardless of RTL
Indeed
list-group is enough
MUCH better!
We also need in template-rtl
.main-nav .fa{margin:0 18px}// same as LTRto get
instead of
.main-nav .fa{margin:0 12px 0 8px}