Feeling Lucky
?
[#21098] - Exceptions in Joomla\CMS\Table\Usergroup refer to categories
- Fixed in Code Base
- 13 Jul 2018
- Medium
- Build: staging
- # 21098
- Diff
- brianteeman:exveptions
User tests: Successful: Unsuccessful:
Pull Request for Issue #21092 .
Summary of Changes
remove todo that is clearly a copy paste error from somewhere else
change exception message to usergroups from catergory
NOTE the first exceptionif ($this->id == 0)
I am not sure if that should even be present - doesn't look like it to me - please advise
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
brianteeman
- comment
- 13 Jul 2018
suggestions for the text welcome
mbabker
- comment
- 13 Jul 2018
"Usergroup not found" or "Could not load usergroup to delete" or something along those lines. Either way it's definitely not something that needs a "Global" modifier.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-13 13:18:13 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 13 Jul 2018
LGTM - thanks!
brianteeman
- comment
- 13 Jul 2018
thanks
I'd say the text on it is bad. Basically, if you don't pass something to the
$oidparam or$this->load()fails then that condition would be met.