Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21095] - [com_menus] Remove useglobal

? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
13 Jul 2018

Pull Request for Issue #20846.

Summary of Changes

This removes useglobal attribute from fields that don't actually use global values.

Testing Instructions

Code review.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 13 Jul 2018
avatar SharkyKZ SharkyKZ - change - 13 Jul 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jul 2018
Category ⇒ Administration com_menus
avatar carlitorweb
carlitorweb - comment - 13 Jul 2018

I have tested this item ✅ successfully on 559ad11

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21095.

avatar carlitorweb carlitorweb - test_item - 13 Jul 2018 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 13 Jul 2018

Is possible then mark the global param, as deprecated or something for J4? Because now is a field no have any use on the core (as before too)

avatar SharkyKZ
SharkyKZ - comment - 13 Jul 2018

As explained in #20846 (comment), global setting is used when accessing component without menu item. Here's the code that does it:

joomla-cms/libraries/src/Application/SiteApplication.php

Lines 346 to 365 in bbd7bdd

// Retrieve com_menu global settings
$temp = clone ComponentHelper::getParams('com_menus');
// Lets cascade the parameters if we have menu item parameters
if (is_object($menu))
{
// Get show_page_heading from com_menu global settings
$params[$hash]->def('show_page_heading', $temp->get('show_page_heading'));
$params[$hash]->merge($menu->params);
$title = $menu->title;
}
else
{
// Merge com_menu global settings
$params[$hash]->merge($temp);
// If supplied, use page title
$title = $temp->get('page_title', $title);
}

avatar barbarosuntorunu barbarosuntorunu - test_item - 23 Jul 2018 - Tested successfully
avatar barbarosuntorunu
barbarosuntorunu - comment - 23 Jul 2018

I have tested this item ✅ successfully on 559ad11

I already look codes. And it work succesfuly

@icampus

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21095.
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Jul 2018
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Jul 2018

Ready to Commit after two successful tests.

avatar durubayram durubayram - test_item - 23 Jul 2018 - Tested successfully
avatar durubayram
durubayram - comment - 23 Jul 2018

I have tested this item ✅ successfully on 559ad11

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21095.

avatar fatmaakay fatmaakay - test_item - 23 Jul 2018 - Tested successfully
avatar fatmaakay
fatmaakay - comment - 23 Jul 2018

I have tested this item ✅ successfully on 559ad11

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21095.

avatar mbabker mbabker - close - 24 Jul 2018
avatar mbabker mbabker - merge - 24 Jul 2018
avatar mbabker mbabker - change - 24 Jul 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-07-24 00:15:33
Closed_By ⇒ mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment