[#21088] - [4.0][a11y]Redundant tabindex - login page
- Fixed in Code Base
- 12 Jul 2018
- Medium
- Build: staging
- # 21088
- Diff
- zwiastunsw:loginpage
User tests: Successful: Unsuccessful:
A positive tabindex value is present in two input field and in button element. Tabindex values of 1 or greater specify an explicit tab/navigation order for page elements. Because it modifies the default tab order, cause confusion, and result in decreased keyboard accessibility, it should be avoided.
How to fix it
If the natural tab order is already logical, remove the tabindex. Otherwise, consider restructuring the page so that tabindex is not needed. If tabindex is maintained, ensure that the resulting navigation is logical and complete.
See:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin |
@zwiastunsw you have to remove all tabindex attributes here, this is totally wrong (hardcoding tabindex!!!!!)
Also you have to insert for username:
autocomplete="username"
For password:
autocomplete ="password"
... etc
Ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input
@dgrammatiko: Why is this wrong? The order of the tabulations shall follow the order of the code.
@zwiastunsw we're in the same page here, somehow I missed that you removed all the tabindexes here.
Still you need to fix the autocomplete or people will complain again (that was the reason to hardcode the tabindexes in the first place)
I agree that there is a need to add an autocomplete. In addition, you still need to delete the fieldset tag or add legends. I will do this in the new PR
the tab index was there because of the j3 login having clickable links on the icons
You need to remove tabindex=4 from here https://github.com/zwiastunsw/joomla-cms/blob/loginpage/administrator/modules/mod_login/Helper/LoginHelper.php#L61
| Labels |
Added:
?
?
|
||
| Category | Unit Tests Repository Administration com_admin | ⇒ | Modules Administration |
Done
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-12 20:50:46 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? ? |
||
I have tested this item✅ successfully on 1b0a811
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21088.