Joomla! Issue Tracker | Joomla! CMS #21082 - [4.0] Modal dismiss button

Fixed in Code Base
19 Jul 2018
Medium
Build: 4.0-dev
# 21082
Diff
chmst:modal-dismiss-button

Pending

User tests: Successful: Unsuccessful:

chmst
11 Jul 2018

Pull Request for Issue # .

Summary of Changes

The dismiss button in the modal header is not read correctly by the screan reader. It reads "multiplication operator" - depending on the language. In German "mal" (2 x 2 = 4).
The PR adds a aria label "closed" and hides the "X" which is read as "multiplication operator", so the screen reader reads "close".

Testing Instructions

Open a modal, for example in articles overview, Batch-Button.
Hear what the screen reader says before and after the Patch.
Make sure that the dismiss-button is the same before and after the patch.

Documentation Changes Required

chmst - open - 11 Jul 2018

chmst - change - 11 Jul 2018

Status

New

⇒

Pending

joomla-cms-bot - change - 11 Jul 2018

Category

Administration com_users Language & Strings Layout

⇒

Layout

zwiastunsw - test_item - 12 Jul 2018 - Tested successfully

zwiastunsw - comment - 12 Jul 2018

I have tested this item ✅ successfully on 1800d8e

Env.: Windows 10, NVDA 2018.2.1

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21082.}

chmst - change - 12 Jul 2018

Labels

Removed: ?

SharkyKZ - comment - 12 Jul 2018

Opinions on Close vs Cancel for closing modals?

SharkyKZ - comment - 12 Jul 2018

By the way, there's PR #20682 for 3.x that includes this fix. If it gets merged, it should reach 4.0 eventually.

brianteeman - comment - 12 Jul 2018

In this case as we have a pr elsewhere for j3 we should fix it there and then it will be ported to j4 by @wilsonge

chmst - comment - 12 Jul 2018

@SharkyKZ Both is possible. If I see only a message, as in an alert, then I would say "close" but "cancel" is not wrong. In a Modal with a form in it, closing the modal also cancels every input. So Cancel is valid in both cases.

a7d0151 12 Jul 2018