[#21079] - [4.0] Fix footer button markup in modal
- Closed
- 16 Jul 2018
- Medium
- Build: 4.0-dev
- # 21079
- Diff
- Quy:patch-4
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #20499 .
Summary of Changes
Fix footer button markup in modal to be consistent with other modals.
Testing Instructions
Go to Users > User Notes
Create a new note
Click on the User icon (See Cancel button)
Click on the Select button (See Close button)
or
Code review via page source
Before:
<a type="button" class="btn btn-secondary" data-dismiss="modal">Cancel</a>
After:
<a role="button" class="btn btn-secondary" data-dismiss="modal" aria-hidden="true">Close</a>
Expected result
Buttons markup to be the same.
Actual result
Buttons markup are different.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
<button type="button" ...
type="button" is the critical part here as it will not interfere with form submission (default behaviour on FF and Chrome)
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-16 13:30:11 |
| Closed_By | ⇒ | Quy |
Closing in favor for PR #20682
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21079.
If it is to be a button, use the
buttontag, not the anchor.An anchor with a role="button" is as bad as an anchor with a type="button" attribute.