? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
11 Jul 2018

Pull Request for Issue #20499 .

Summary of Changes

Fix footer button markup in modal to be consistent with other modals.

Testing Instructions

Go to Users > User Notes
Create a new note
Click on the User icon (See Cancel button)
Click on the Select button (See Close button)

or

Code review via page source

Before:
<a type="button" class="btn btn-secondary" data-dismiss="modal">Cancel</a>

After:
<a role="button" class="btn btn-secondary" data-dismiss="modal" aria-hidden="true">Close</a>

Expected result

Buttons markup to be the same.

Actual result

Buttons markup are different.

Documentation Changes Required

none

avatar Quy Quy - open - 11 Jul 2018
avatar Quy Quy - change - 11 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2018
Category Layout
avatar zwiastunsw
zwiastunsw - comment - 11 Jul 2018

If it is to be a button, use the button tag, not the anchor.
An anchor with a role="button" is as bad as an anchor with a type="button" attribute.

avatar dgrammatiko
dgrammatiko - comment - 11 Jul 2018

<button type="button" ...

type="button" is the critical part here as it will not interfere with form submission (default behaviour on FF and Chrome)

avatar Quy
Quy - comment - 11 Jul 2018

This is fixed in #20682 for v3. Will this be merged into v4 eventually? If yes, then I can close this PR.

avatar brianteeman
brianteeman - comment - 11 Jul 2018

if #20682 is merged in j3 then it will eventually be merged here as well

avatar Quy Quy - change - 16 Jul 2018
Labels Added: ?
avatar Quy Quy - close - 16 Jul 2018
avatar Quy Quy - change - 16 Jul 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-07-16 13:30:11
Closed_By Quy
avatar Quy
Quy - comment - 16 Jul 2018

Closing in favor for PR #20682


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21079.

Add a Comment

Login with GitHub to post a comment