Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21031] - [com_tags] All Tags default layout

? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
10 Jul 2018

Pull Request for Issue # .

Summary of Changes

This fixes the issue of default all tags layout setting not being respected. Also removes some misplaced code.

Testing Instructions

Create an alternative All Tags layout (in /components/com_tags/views/tags/tmpl/ or /templates/protostar/html/com_tags/tags/).
Go to com_tags configuration and select new layout under Default List All Tags Layout setting.
Enter all tags view directly (index.php?option=com_tags&view=tags).

Expected result

Selected layout is used.

Actual result

Selected layout not used.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 10 Jul 2018
avatar SharkyKZ SharkyKZ - change - 10 Jul 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jul 2018
Category ⇒ com_tags Front End
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2018

Can't get this PR working:

As wroting in Test Instructions created an alternative All Tags layout:

bildschirmfoto 2018-07-11 um 16 03 23

In "Tag Options" selected the new Layout:

bildschirmfoto 2018-07-11 um 16 05 19

Entered all tags view directly (index.php?option=com_tags&view=tags) but get with and -out PR same Result:

bildschirmfoto 2018-07-11 um 16 02 05

System information

  • 3.8.11-dev
  • Template: Protostar
  • macOS Sierra, 10.13.6
  • Firefox 61 (64-bit)

CloudAccess.net

  • PHP 7.0.28
  • MySQLi 5.7.18-cll-lve
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Jul 2018 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2018

I have tested this item 🔴 unsuccessfully on 9be6cfc

as described above.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

avatar SharkyKZ
SharkyKZ - comment - 12 Jul 2018

@franz-wohlkoenig did you make any changes to custom layout? You need something to tell the two layouts apart.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 12 Jul 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Jul 2018

I have tested this item ✅ successfully on 9be6cfc

Thanks for Info, @SharkyKZ

I changed the Size of Tag-Title from h3 up to h1; using PR at "index.php?option=com_tags&view=tags" Title is shown in h1.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

avatar FPerisa FPerisa - test_item - 16 Aug 2018 - Tested successfully
avatar FPerisa
FPerisa - comment - 16 Aug 2018

I have tested this item ✅ successfully on 9be6cfc

My test layout has a new paragraph and I can see it only after applying this patch.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21031.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Aug 2018
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Aug 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 21 Aug 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-08-21 03:53:43
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 21 Aug 2018
avatar mbabker mbabker - merge - 21 Aug 2018

Add a Comment

Login with GitHub to post a comment