? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
7 Jul 2018

Replacement Pull Request for PR #8431

Summary of Changes

Replaces PR #8431 after resolving merge conflicts. See original PR for details.

11ebaaf 11 Jan 2016 avatar andrepereiradasilva ups
avatar mbabker mbabker - open - 7 Jul 2018
avatar mbabker mbabker - change - 7 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jul 2018
Category Administration Language & Strings Front End Plugins
avatar rdeutz
rdeutz - comment - 3 Sep 2018

@mbabker any idea why the test on AppVeyor failed?

  1. JCacheStorageCacheliteTest::testCacheTimeout
    Some data should be available in lifetime.
    Failed asserting that false matches expected 'testData'.
    C:\projects\joomla-cms\tests\unit\core\case\cache.php:121
    C:\projects\joomla-cms\tests\unit\suites\libraries\joomla\cache\storage\JCacheStorageCacheliteTest.php:67
avatar mbabker
mbabker - comment - 3 Sep 2018

False positive, especially since the other two builds did pass. Anyway I triggered a rebuild.

avatar zero-24 zero-24 - change - 3 Sep 2018
Title
Cache Plugin improvements (Replaces #8431)
[3.9] Cache Plugin improvements (Replaces #8431)
avatar zero-24 zero-24 - edited - 3 Sep 2018
avatar rdeutz rdeutz - change - 3 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-03 17:04:49
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 3 Sep 2018
avatar rdeutz rdeutz - merge - 3 Sep 2018
avatar zero-24
zero-24 - comment - 4 Sep 2018

@mbabker could it be that this result into an B/C change? Because # is different in regex than / I'm notice this because the examples have been changed too. Or is this just me who knows nearly nothing about regex?

avatar mbabker
mbabker - comment - 4 Sep 2018

You're asking the wrong person. I branched the original PR, resolved merge conflicts, and opened a new one.

Likewise, plugins don't fall under the same B/C scrutiny as the core API. Plus cache is flushed on an update. So I'm not quite sure what the B/C concern here could be.

avatar zero-24
zero-24 - comment - 4 Sep 2018

Well my point is that it it looks like the old configuration value (\/component\/users\/) does not work anymore but i have no idea if that is true. I have just noticed that the description was changed so better safe than sorry.

Add a Comment

Login with GitHub to post a comment