? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
6 Jul 2018

This is the main body of work on the redesigned backend template per @svom and @coolcat-creations awesome new design in the Joomla Magazine from November.

https://magazine.joomla.org/issues/issue-nov-2017/item/3289-episode-iv-a-new-user-interface-for-the-joomla-backend

Clearly this isn't finished but should be as useable as the current one (so yes that means it's missing mobile design, it's missing RTL etc)

This is a PR so that some basic sanity testing can happen before it is merged and so the system tests can be fixed

TODO BEFORE MERGING

  • Fix system tests (probably merge joomla/test-system#45 and then swap the default branch here back to the main 4.0-dev branch)
  • Fix hound (it only errors on the compiled es5 files and a boostrap vendor file so i guess it's just setting up the right ignores)
9efa5ff 19 Feb 2018 avatar ciar4n Init
e410224 19 Feb 2018 avatar dgrammatiko again
84f8cbf 19 Feb 2018 avatar ciar4n tweak
avatar wilsonge wilsonge - open - 6 Jul 2018
avatar wilsonge wilsonge - change - 6 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2018
Category Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_config com_contact com_content com_contenthistory com_cpanel
avatar wilsonge wilsonge - change - 6 Jul 2018
Labels Added: ?
avatar brianteeman
brianteeman - comment - 6 Jul 2018

I would say that as soon as the automated tests pass then this should be merged. its too big and unwieldy a pr to really comment on anything else right now. Especially as we know its not complete.

avatar wilsonge wilsonge - change - 6 Jul 2018
The description was changed
avatar wilsonge wilsonge - edited - 6 Jul 2018
avatar brianteeman
brianteeman - comment - 8 Jul 2018

I know the menu has changed but why have the admin presets been removed? The ability to import preset is still present but now errors

avatar wilsonge wilsonge - change - 9 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-09 23:49:36
Closed_By wilsonge
avatar wilsonge wilsonge - close - 9 Jul 2018
avatar wilsonge wilsonge - merge - 9 Jul 2018
avatar mbabker
mbabker - comment - 10 Jul 2018

Someone tell me it's an intentional decision to not link to the module manager ANYWHERE but the control panel quick icon please.

avatar infograf768
infograf768 - comment - 10 Jul 2018

@coolcat-creations
I do not have this layout here at all. Including the icons

I just updated an existing test site via eclipse. Anything I should do?

avatar coolcat-creations
coolcat-creations - comment - 10 Jul 2018

@infograf768 - as @wilsonge stated in the PR it's absolutely not in the state to be finished ...
Please take the invision prototype and the jcm article as a reference...

avatar dgrammatiko
dgrammatiko - comment - 10 Jul 2018

@mbabker the menu transformation is not complete atm! There are still items that need to be removed from the menu and others that need to be added (eg modules), the first step was to get the 2 views system and help in place and then patch the rest. This is not the final, production ready code, even the menu logic (js) is not yet updated, so please bear with us as we’ll try to finish this task

avatar Hackwar
Hackwar - comment - 10 Jul 2018

It would be really good if only production-ready code would be commited to this repository... It doesn't look like this PR was ready to be merged.

avatar infograf768
infograf768 - comment - 10 Jul 2018

Please take the invision prototype and the jcm article as a reference...

No idea what it means but I will be patient.
Nevertheless please do add the Save and Close button separately.
We really miss that...

avatar dgrammatiko
dgrammatiko - comment - 10 Jul 2018

@Hackwar I think due to lack of people working on the other repo the decision was to move the code here so more devs can contribute and thus accelerate the process. The j4 menu is known to been far from production ready code since the first alpha, nothing new here

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Jul 2018
avatar Hackwar
Hackwar - comment - 10 Jul 2018

@dgrammatiko I don't want to complain to much, because I've been guilty of this in the past, too, but I still want us to be able to release at any time with this repo. Merging unfinished code prevents that. From a quick glance, this is in the state of work-in-progress and thus not even in alpha state. Don't get me wrong, I value the work that is being done here, but I'd rather have this split up into X PRs which are only merged when ready. Even if it looks a bit strange from time to time because new code doesn't really fit visually with old code, at least everything would work...

avatar brianteeman
brianteeman - comment - 10 Jul 2018

but I still want us to be able to release at any time with this repo.

for reasons (that i don't agree with) it was decided that this was not to be the case at this stage of J4 development

avatar mbabker
mbabker - comment - 10 Jul 2018

1.4.1 Stable master branches
It is critical to our mission that the master branch of each major version of a Joomla product is always stable and ready for a release within a short time. This is supported by our Contributor Policy.

https://developer.joomla.org/development-strategy.html

avatar rdeutz
rdeutz - comment - 10 Jul 2018

good that we have renamed the main branch to staging :-P

avatar wilsonge
wilsonge - comment - 10 Jul 2018

I've said since JAB that I'm also starting to tighten up on the stuff I'm merging as I understand the repo now needs to move towards stability. Getting the new template design in was the one last missing part. Given the existing template was also broken in many ways I'd rather stop getting PRs to fix something that is broken and getting replaced and put in something that is nearly as

PR for the missing module menu item: #21032

avatar dgrammatiko
dgrammatiko - comment - 11 Jul 2018

always stable and ready for a release within a short time

So how the heck an alpha or even beta version can be stable and ready for a release within a short time?
By definition alpha and beta are nowhere near production ready or have we also have another definition for alpha and beta in this project?

I'm confused ?‍♂️

avatar Bakual
Bakual - comment - 11 Jul 2018

So how the heck an alpha or even beta version can be stable and ready for a release within a short time?

If you look at our staging (J3) branch, it is basically production ready even when not tagged at all. "Alpha" doesn't mean it is broken (it may of course but doesn't have to). It means that the API may still change. "Beta" also doesn't mean it is broken, but it is "Feature Complete" and we don't expect any API changes anymore. RCs are then when we don't expect any changes anymore to the stable release except when we detect some new bugs, languages are usually also frozen at this point.
See https://en.wikipedia.org/wiki/Software_release_life_cycle.

avatar rdeutz
rdeutz - comment - 11 Jul 2018

4.0-dev is a development branch so the rule doesn't apply, our staging branch should be always in a state that we can make a release in a short time frame. If we have a 4.0-staging branch, then the rule will apply.

avatar zero-24
zero-24 - comment - 11 Jul 2018

@wilsonge this is a rater imported PR to be added to the 4.0 milestone :P Just for the record i have also added the new feature label.

Add a Comment

Login with GitHub to post a comment