Feeling Lucky
?
?
[#21002] - [4.0][a11y]Convert link to a button in sample data admin module
- Fixed in Code Base
- 11 Jul 2018
- Medium
- Build: 4.0-dev
- # 21002
- Diff
- wojsmol:patch-10
User tests: Successful: Unsuccessful:
Pull Request for Issue #20997
Summary of Changes
The Install button in Sample data module is incorrectly marked as a link.
See:
- 1.3.1 Info and Relationships (Level A)
- G115: Using semantic elements to mark up structure
- Links vs. Buttons in Modern Web Applications
Testing Instructions
code review and check if install buttons in sape data module are working.
Expected result
Install button in sample data module is a button.
Actual result
Install button in sample data module is a link.
Documentation Changes Required
N/A
cc @zwiastunsw @chmst please test
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
brianteeman
- | Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
zwiastunsw
- comment
- 6 Jul 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21002.
SharkyKZ
- comment
- 6 Jul 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21002.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 6 Jul 2018
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-11 07:31:33 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 11 Jul 2018
Sorry for the delay in merging. Thanks!
Add
type="button"attribute.