Success

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
1 Oct 2013

@infograf768 has to review if this is correct and create the required issues

avatar phproberto phproberto - open - 1 Oct 2013
avatar infograf768
infograf768 - comment - 2 Oct 2013

We have to add a conditional in the new method to get rid of a Notice when the languagefilter is disabled:

  • if (JLanguageMultilang::isEnabled())
  • {
  • // If already tested, don't test again.
  • if (!$tested)
  • {
  • $params = new JRegistry(JPluginHelper::getPlugin('system', 'languagefilter')->params); +
  • $enabled = (boolean) $params->get('item_associations', false);
  • $tested = true;
  • }
  • }

otherwise, I tested the patch and the changes to form.php work real good!
(do we need to keep $app = JFactory::getApplication(); ?)

avatar phproberto
phproberto - comment - 2 Oct 2013

Updated the PR. Here seems to work.

All yours

avatar infograf768 infograf768 - close - 3 Oct 2013
avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment