Pending

User tests: Successful: Unsuccessful:

avatar rmcdaniel
rmcdaniel
16 May 2012

This adds ACL to the menu manager. Most of the code was copied from the content manager. I tried to follow all the conventions in the original code. I hope this helps!

avatar rmcdaniel rmcdaniel - open - 16 May 2012
avatar elinw
elinw - comment - 16 May 2012

You don't want to totally remove permissions from the component since those provide the fall backs that are used in absence of specific settings. Ideally you only use the item level ones in special cases, similar to the article level permissions in content.

avatar infograf768
infograf768 - comment - 17 May 2012

Also, please add a Feature Tracker on joomlacode an reference back here:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

Forgot:
You are deleting in this patch a new string just committed:
COM_MENUS_ITEM_FIELD_HIDE_UNASSIGNED="Hide Unassigned Modules"

avatar rmcdaniel rmcdaniel - close - 17 May 2012
avatar rmcdaniel
rmcdaniel - comment - 17 May 2012

I didn't remove the component permissions. I just moved them to the access.xml file along with the menu type and menu item permissions. Also, I see now in this patch that I didn't use the newest files when I made my changes. I'll close this request, fix it, create a feature tracker and then submit a new pull request. Thanks!

avatar elinw
elinw - comment - 17 May 2012

You shouldn't need to move the access.xml from where it was.

avatar rmcdaniel
rmcdaniel - comment - 17 May 2012

When I started, com_menus didn't have an access.xml. I created it and then moved the component permissions to the new access.xml from config.xml so it would look more like com_content. Looking at the commit, I don't think the access.xml I created got added. Sorry for the confusion, I'm a bit new to Git.

avatar elinw
elinw - comment - 19 May 2012

Oh I see it was just using the default.

avatar coolbung coolbung - reference | 67879f1 - 14 Sep 13

Add a Comment

Login with GitHub to post a comment