[#20998] - [4.0][a11y]Remove incorrect role attribute
- Fixed in Code Base
- 10 Jul 2018
- Medium
- Build: 4.0-dev
- # 20998
- Diff
- wojsmol:patch-13
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #20992
Summary of Changes
The links in the Quickicon module are assigned the role=button attribute. This is incorrect. These are not buttons. These are the links that open new pages
Testing Instructions
code review
Expected result
The links in the Quickicon module are not assigned the role=button attribute.
Actual result
The links in the Quickicon module are assigned the role=button attribute.
Documentation Changes Required
N/A
cc @zwiastunsw @chmst please test
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20998.
Thank you for testing @zwiastunsw @chmst
Based on the code, the link could have onclick in which case it could act as a button. Maybe append role to onclick?
$onclick = empty($displayData['onclick']) ? '' : (' onclick="' . $displayData['onclick'] . '" role="button"');
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-10 14:48:38 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on c27297c
After inspecting the code - this is correct, as the quick icons are links.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20998.