[#20991] - [4.0] Finish moving error templates to proper HtmlDocument structure
- Fixed in Code Base
- 17 Jul 2018
- Medium
- Build: 4.0-dev
- # 20991
- Diff
- mbabker:4.0-error-templates
User tests: Successful: Unsuccessful:
Summary of Changes
Finishing #20734 the system and installation app error templates are updated to reflect the error document now being an extension of the HTML document.
Testing Instructions
- Temporarily rename
error.phpin the themed templates to anything else temporarily so the system template'serror.phplayout is rendered - Trigger error page
- See error page
- Rename the
error.phpfile(s) you previously renamed back toerror.php - Mark successful test
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Installation Front End Templates (site) |
Throw an exception somewhere.
The paths are fine because it's not doing relative lookups (in which case you have to do full paths from the app root versus the "shorthand" stuff).
but for installation isnt the app root example.com/installation?
By app root I meant JPATH_ROOT basically.
Given we’re rendering error pages would it be better to use JDocument to include style sheets and scripts to minimise the libraries were practically using for the error page?
IMO no. The full API should be available when it comes to rendering an error page, when it's being rendered simply means some error went unhandled, not that the API is unavailable. Remember with #20109 in place our error page renderer honestly will only trigger at a point after the API should be stable, any earlier errors it's hitting Symfony's handler.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-17 12:24:49 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I forgot we'd added the symfony handler :)
Any idea how to trigger the error page during installation because I think the paths are wrong