J4 Issue ?
avatar brianteeman
brianteeman
5 Jul 2018

in #18357 and #18326 I spent a lot of time ensuring that the pagination was fully accessible. That code needs to be ported across to J4

I still don't understand why we have an override for this in atum

avatar brianteeman brianteeman - open - 5 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Jul 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Jul 2018
Category Accessibility com_content Templates (admin)
avatar brianteeman brianteeman - change - 5 Jul 2018
Title
[4.0] [a11y] Atum pagination
[4.0] [a11y] pagination
avatar brianteeman brianteeman - edited - 5 Jul 2018
avatar brianteeman brianteeman - change - 5 Jul 2018
The description was changed
avatar brianteeman brianteeman - edited - 5 Jul 2018
avatar brianteeman brianteeman - change - 6 Jul 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 6 Jul 2018
avatar brianteeman
brianteeman - comment - 29 Jul 2018

I started working on this but have a question the code below is being used

* @note As of 4.0 this method will proxy to `\JLayoutHelper::render('joomla.pagination.link', ['data' => $item, 'active' => true])`

and not the layout despite the comment.

I don't want to do the work multiple times so what needs to be changed.

avatar mbabker
mbabker - comment - 29 Jul 2018

Eventually, yes, those methods should be updated to just use the layouts versus the markup that's in those methods now.

avatar brianteeman
brianteeman - comment - 29 Jul 2018

So I just replaces the code there with this


	protected function _item_active(PaginationObject $item)
		{
		return \JLayoutHelper::render('joomla.pagination.link', ['data' => $item, 'active' => true])
		}
avatar mbabker
mbabker - comment - 29 Jul 2018

Yes.

avatar brianteeman
brianteeman - comment - 29 Jul 2018

thought so - that results in nothing being output so I guess there is another bug - will investigate

avatar brianteeman
brianteeman - comment - 29 Jul 2018

found the error - pebkac

avatar brianteeman brianteeman - change - 29 Jul 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-07-29 18:26:53
Closed_By brianteeman
avatar brianteeman brianteeman - close - 29 Jul 2018

Add a Comment

Login with GitHub to post a comment