Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#20972] - [4.0] Timezone field - duplicate class

?
avatar brianteeman
brianteeman
4 Jul 2018

If you view the source of com_config you will see duplicate classes. This is invalid markup

<div class="controls"><select id="jform_offset" name="jform[offset]" class="custom-select" class="custom-select">
 
The first one comes from

joomla-cms/libraries/src/Form/Field/GroupedlistField.php

Line 151 in 4b01c64

$attr .= !empty($this->class) ? ' class="custom-select ' . $this->class . '"' : ' class="custom-select"';

The second one comes from

joomla-cms/libraries/cms/html/select.php

Line 222 in 4b01c64

. ' name="' . $name . '"' . $attribs . ' class="custom-select">' . $options['format.eol'];

avatar brianteeman brianteeman - open - 4 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 4 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Jul 2018
The description was changed
Status New ⇒ Discussion
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2018
Status Discussion ⇒ New
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2018
Status New ⇒ Discussion
avatar joomla-cms-bot joomla-cms-bot - edited - 4 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - edited - 4 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Jul 2018
Category ⇒ Code style com_config
avatar Quy
Quy - comment - 4 Jul 2018

Related PR #20196

avatar brianteeman
brianteeman - comment - 4 Jul 2018

You can see the same in other places such as the module style field

avatar brianteeman
brianteeman - comment - 4 Jul 2018

Closed as a duplicate

avatar brianteeman brianteeman - change - 4 Jul 2018
Status Discussion ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-07-04 11:41:00
Closed_By ⇒ brianteeman
avatar brianteeman brianteeman - close - 4 Jul 2018

Add a Comment

Login with GitHub to post a comment