? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
3 Jul 2018

Pull Request for Issue #20960 .

Summary of Changes

allow form submission if Google Recaptcha v1 enabled

Will allow spamming of forms configured with v1 captcha where those forms are relying on the (broken/discontinued) API, but will now also provide backward compatibility allowing of real users to submit the form.

Will remove the JS warnings in Console.

Testing Instructions

Configure Google recaptcha v1 with a fake key

Expected result

You can still submit forms - proving b/c works and the absence of a working google api is not blocking form submissions

avatar PhilETaylor PhilETaylor - open - 3 Jul 2018
avatar PhilETaylor PhilETaylor - change - 3 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2018
Category Front End Plugins
62abdf2 4 Jul 2018 avatar PhilETaylor tabs
avatar PhilETaylor PhilETaylor - change - 4 Jul 2018
Labels Added: ?
avatar Quy
Quy - comment - 4 Jul 2018

Should methods _recaptcha_qsencode and _recaptcha_http_post be removed?

avatar PhilETaylor
PhilETaylor - comment - 4 Jul 2018

like I said here, this is a very light handed approach, removing the least amount just to stop b/c and allow forms to work. Removing whole methods which could in theory be used (haahahah as if) by developers is a b/c break.

avatar Quy Quy - test_item - 4 Jul 2018 - Tested successfully
avatar Quy
Quy - comment - 4 Jul 2018

I have tested this item successfully on 62abdf2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20965.

avatar mbabker
mbabker - comment - 4 Jul 2018

They're private methods. If you're using them (because the only way to do it is through a hack, i.e. Reflection), you deserve the break.

avatar brianteeman
brianteeman - comment - 9 Jul 2018

On a site I just visited with recaptcha1 I saw this

chrome_2018-07-09_23-41-33

avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-02-10 21:36:17
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 10 Feb 2019

Add a Comment

Login with GitHub to post a comment