? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Jul 2018

Changes

  • Added language file
  • Changed to a protected extension
  • Updated code comments
  • Removed onExtensionAfterSave (I dont think that ever happens?)

Possible improvements and Issues to solve

  • add a button to manually regenerate the file

  • we are writing to a folder /libaries that we haven't written to in the past and so might not be writable. To test I made the libraries folder readonly and I didnt get any error message about not being able to build the map when i installed or deleted an extension

@wilsonge here you are

avatar brianteeman brianteeman - open - 2 Jul 2018
avatar brianteeman brianteeman - change - 2 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2018
Category SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins
avatar wilsonge
wilsonge - comment - 2 Jul 2018

onExtensionAfterSave definitely does happen - but it's when com_config, languages, modules, plugins or template styles are saved. I guess that shouldn't affect the namespaces in the extension - so should be safe to remove it :)

we are writing to a folder /libaries that we haven't written to in the past and so might not be writable. To test I made the libraries folder readonly and I didnt get any error message about not being able to build the map when i installed or deleted an extension

Presumably this would also mean any extension with a library would also not be able to be installed through the updater though?

avatar brianteeman
brianteeman - comment - 2 Jul 2018

Presumably this would also mean any extension with a library would also not be able to be installed through the updater though?

Yes but they are rare. Either way there should be an error message if the file can not be created

avatar wilsonge wilsonge - change - 2 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-02 10:43:25
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 2 Jul 2018
avatar wilsonge wilsonge - merge - 2 Jul 2018
avatar wilsonge
wilsonge - comment - 2 Jul 2018

Could open an issue for those improvements so I don't loose track of them please? But I agree with them! On top of those two I'm also tempted to rebuild the file on every page load if the Joomla version isn't stable (similar check for deleting installation dir)

Add a Comment

Login with GitHub to post a comment