? ? ? Pending

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
1 Jul 2018

Pull Request for Issue # .

Summary of Changes

Make the PLG_TWOFACTORAUTH_TOTP_STEP3_TEXT text clearer.

Testing Instructions

code review

Expected result

User know which button select to pass step 3 of initial configuration.

Actual result

User don't know which button select to pass step 3 of initial configuration - see https://forum.joomla.org/viewtopic.php?f=706&t=863546.

Documentation Changes Required

avatar wojsmol wojsmol - open - 1 Jul 2018
avatar wojsmol wojsmol - change - 1 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2018
Category Administration Language & Strings
avatar wojsmol wojsmol - change - 1 Jul 2018
Title
make the text clealer
[J3] Make the text clearer
avatar wojsmol wojsmol - edited - 1 Jul 2018
avatar wojsmol wojsmol - change - 1 Jul 2018
Title
[J3] Make the text clearer
[3.8] Make the text clearer
avatar wojsmol wojsmol - edited - 1 Jul 2018
avatar brianteeman
brianteeman - comment - 1 Jul 2018

Yes its a bug that needs fixing. Good spot. But can you look at the similar string for the yubikey plugin and adjust this one to match

avatar wojsmol
wojsmol - comment - 1 Jul 2018

For yubikey we have
PLG_TWOFACTORAUTH_YUBIKEY_STEP1_TEXT="Please insert your YubiKey device into your computer's USB port. Select the Security Code field below. Then touch the gold disk on your YubiKey device for one second. Afterwards, please save your user profile. If the code generated by your YubiKey is validated by YubiCloud the Two Factor Authentication feature will be enabled and this YubiKey will be linked with your user account."
Witch text you prefer?

avatar brianteeman
brianteeman - comment - 1 Jul 2018

Afterwards, please save your user profile. If the code is correct, the Two Factor Authentication feature will be enabled.

avatar wojsmol wojsmol - change - 1 Jul 2018
Labels Added: ? ?
avatar Quy
Quy - comment - 1 Jul 2018

How about in the field below and save your user profile.?

avatar wojsmol
wojsmol - comment - 1 Jul 2018

@brianteeman Please comment on #20940 (comment).

avatar brianteeman
brianteeman - comment - 1 Jul 2018

i stick by my original comment

avatar wojsmol
wojsmol - comment - 11 Jul 2018

PR in ready for testing.

avatar bene-we bene-we - test_item - 24 Jul 2018 - Tested successfully
avatar bene-we
bene-we - comment - 24 Jul 2018

I have tested this item successfully on 8c6a841

Description is much clearer now

@icampus


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20940.

avatar Quy Quy - test_item - 24 Jul 2018 - Tested successfully
avatar Quy
Quy - comment - 24 Jul 2018

I have tested this item successfully on 8c6a841


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20940.

avatar Quy Quy - change - 24 Jul 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 Jul 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20940.

avatar roland-d roland-d - change - 24 Jul 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-24 13:29:07
Closed_By roland-d
Labels Added: ?
avatar roland-d roland-d - close - 24 Jul 2018
avatar roland-d roland-d - merge - 24 Jul 2018

Add a Comment

Login with GitHub to post a comment